Error in published patch to smbd/filename.c

[Richard Bollinger]

That would be a nice assumption which apparently doesn't hold on my system
using GCC 2.7.2.3 with Solaris 2.6.  The prior patch fails.

Rich B
----- Original Message -----
From: "Jeremy Allison" <jeremy at valinux.com>
To: "Richard Bollinger" <rabollinger at home.com>
Cc: <samba-technical at us5.samba.org>; <jra at samba.org>
Sent: Monday, November 20, 2000 3:36 PM
Subject: Re: Error in published patch to smbd/filename.c


> Richard Bollinger wrote:
> >
> > A patch previously sent on this list included a memory leak "fix" for
> > smbd/filename.c which was in error.  It used a local static variable
> > "initialised" which was not defined before use.  The declaration should
have
> > read "static BOOL initialised = False;".
>
> Actually, I don't think it matters as anything defined as
> static and not initialized is automatically put into the BSS
> segment, which is implicitly zero.
>
> Your patch does make the intent clearer though, thanks.
>
> Jeremy.
>
> --
> --------------------------------------------------------
> Buying an operating system without source is like buying
> a self-assembly Space Shuttle with no instructions.
> --------------------------------------------------------