Error in published patch to smbd/filename.c

Jeremy Allison jeremy at valinux.com
Mon Nov 20 20:36:37 GMT 2000


Richard Bollinger wrote:
> 
> A patch previously sent on this list included a memory leak "fix" for
> smbd/filename.c which was in error.  It used a local static variable
> "initialised" which was not defined before use.  The declaration should have
> read "static BOOL initialised = False;".

Actually, I don't think it matters as anything defined as
static and not initialized is automatically put into the BSS
segment, which is implicitly zero.

Your patch does make the intent clearer though, thanks.

Jeremy.

-- 
--------------------------------------------------------
Buying an operating system without source is like buying
a self-assembly Space Shuttle with no instructions.
--------------------------------------------------------




More information about the samba-technical mailing list