fix loadparm.c bug about handling multibyte char.Subject:
Hiroshi MIURA
miura at samba.gr.jp
Wed Jul 5 04:02:22 GMT 2000
Hi, Mr. Tim Potter,
I think that the former is better. So it must do initialize_multib...()
each time that handle_client_coding_system() is called.
I think "saved_character_set" flag is used in order to call interpret_char...()
when there are both character_set and client_code_page parameters
in smb.conf file.
I'm sorry that I put up an ambiguous patch. :-/
This would be better to understand.
*** 2111,2116 ****
--- 2111,2117 ----
Globals.client_code_page = atoi(pszParmValue);
+ initialize_multibyte_vectors(lp_client_code_page());
if (saved_character_set != NULL)
interpret_character_set(saved_character_set,lp_client_code_page());
return(True);
}
In original message "Re: fix loadparm.c bug about handling multibyte char.Subject:"
on 00/07/05, Tim Potter <tpot at linuxcare.com.au> writes:
>
> Hiroshi MIURA writes:
>
> > Hello!!
> >
> > I posted a patch to samba-patches at samba.org
> >
> > This patch fixess a problem in parm/loadparm.c.
> > In lp_load(), it analyse smb.conf, so it recognize
> > line end backslash is as continueing line.
>
> Hiroshi, should this patch be:
>
> *** 2111,2116 ****
> --- 2111,2117 ----
> Globals.client_code_page = atoi(pszParmValue);
> if (saved_character_set != NULL)
> interpret_character_set(saved_character_set,lp_client_code_page());
> + initialize_multibyte_vectors(lp_client_code_page());
> return(True);
> }
>
> or something like this:
>
> ***************
> *** 2109,2116 ****
> static BOOL handle_client_code_page(char *pszParmValue,char **ptr)
> {
> Globals.client_code_page = atoi(pszParmValue);
> ! if (saved_character_set != NULL)
> interpret_character_set(saved_character_set,lp_client_code_page());
> return(True);
> }
>
> --- 2109,2118 ----
> static BOOL handle_client_code_page(char *pszParmValue,char **ptr)
> {
> Globals.client_code_page = atoi(pszParmValue);
> ! if (saved_character_set != NULL) {
> interpret_character_set(saved_character_set,lp_client_code_page());
> + initialize_multibyte_vectors(lp_client_code_page());
> + }
> return(True);
> }
>
>
> Regards,
>
> Tim.
--
SAMBA User Group Japan development staff (miura at samba.gr.jp)
Linux Kernel Hack Japan, BLUE, hiroshi at ChangeLog.net
LUGS:=YLUG,TLUC,TLUG,CLUG,etc..
MIURA, Hiroshi -------> http://www.momokuri.org/
More information about the samba-technical
mailing list