fix loadparm.c bug about handling multibyte char.Subject:

Tim Potter tpot at linuxcare.com.au
Tue Jul 4 23:26:13 GMT 2000


Hiroshi MIURA writes:

> Hello!! 
> 
> I posted a patch to samba-patches at samba.org 
> 
> This patch fixess a problem in parm/loadparm.c.
> In lp_load(), it analyse smb.conf, so it recognize 
> line end backslash is as continueing line. 

Hiroshi, should this patch be:

*** 2111,2116 ****
--- 2111,2117 ----
         Globals.client_code_page = atoi(pszParmValue);
         if (saved_character_set != NULL)
                 interpret_character_set(saved_character_set,lp_client_code_page());     
 +               initialize_multibyte_vectors(lp_client_code_page());
         return(True);
   }

or something like this:

***************
*** 2109,2116 ****
  static BOOL handle_client_code_page(char *pszParmValue,char **ptr)
  {
        Globals.client_code_page = atoi(pszParmValue);
!       if (saved_character_set != NULL)
                interpret_character_set(saved_character_set,lp_client_code_page());
        return(True);
  }
  
--- 2109,2118 ----
  static BOOL handle_client_code_page(char *pszParmValue,char **ptr)
  {
        Globals.client_code_page = atoi(pszParmValue);
!       if (saved_character_set != NULL) {
                interpret_character_set(saved_character_set,lp_client_code_page());
+               initialize_multibyte_vectors(lp_client_code_page());
+       }
        return(True);
  }


Regards,

Tim.



More information about the samba-technical mailing list