'source environment' param and % token subs for 'netbios name'

[David Collier-Brown]

You missed a buglet in do_parameter:
The code expects a success/failure indication from the special
function, but always returns true....

/* if it is a special case then go ahead */
if (parm_table[parmnum].special) {
        parm_table[parmnum].special(pszParmValue,(char **)parm_ptr);
        return(True);
}
instead of
if (parm_table[parmnum].special) {
   return (parm_table[parmnum].special(pszParmValue,(char
**)parm_ptr));
}		

I noticed this yesterday while trying unsucessfully to write a
special for ... netbios name!

Gurus, are the failures being discarded intentionally?
-- 
David Collier-Brown,  | Always do right. This will gratify some people
185 Ellerslie Ave.,   | and astonish the rest.        -- Mark Twain
Willowdale, Ontario   | //www.oreilly.com/catalog/samba/author.html
Work: (905) 415-2849 Home: (416) 223-8968 Email: davecb at canada.sun.com