VFS write not being called (was: VFS imlpementation and caching?)

Brad Sahr bsahr at macromedia.com
Fri Aug 25 23:07:35 GMT 2000

Thanks Jeremy. The change as you've made it works 
for my purposes, but I do have a question.

Since the write_data() function in util_sock.c will
now be bypassed, where does this leave the people
that build with the #define WITH_SSL? Do those calls
to write_data() come down a different path?


> -----Original Message-----
> From: jeremy at valinux.com [mailto:jeremy at valinux.com]
> Sent: Friday, August 25, 2000 1:41 PM
> To: Brad Sahr
> Cc: Samba Technical List
> Subject: Re: VFS write not being called (was: VFS imlpementation and
> caching?)
> Brad Sahr wrote:
> > 
> > The following seems to work. The loop was lifted
> > directly from util_sock.c. Jeremy, will you update
> > fileio.c and let me know when it is updated? If
> > not, could you give me some guidance on doing so?
> > I believe there is going to be more changes needed
> > to fully support the VFS feature (preview: unlink
> > is not getting called within the VFS).
> > 
> Actually, I just committed a different fix (sorry).
> In smbd/vfs.c there already exists vfs_write_data()
> which takes a fsp rather than an fd and then does
> the correct thing. So the fix was to change the write_data()
> call to vfs_write_data().
> I agree I think there are a few more vfs bugs to find,
> but this one was pretty bad :-).
> Fixed now in HEAD. Thanks for the help,
> 	Jeremy.
> -- 
> --------------------------------------------------------
> Buying an operating system without source is like buying
> a self-assembly Space Shuttle with no instructions.
> --------------------------------------------------------

More information about the samba-technical mailing list