[SCM] Samba Shared Repository - branch master updated

Jeremy Allison jra at samba.org
Wed Oct 28 17:53:05 UTC 2020


The branch, master has been updated
       via  5f92ec6988d s4:torture: Pass buffer correctly to write()
      from  d619a57804d s3: update Russian translation of pam_winbind

https://git.samba.org/?p=samba.git;a=shortlog;h=master


- Log -----------------------------------------------------------------
commit 5f92ec6988d2f4c20eab9449cbe17317588f6634
Author: Andreas Schneider <asn at samba.org>
Date:   Wed Oct 28 15:05:34 2020 +0100

    s4:torture: Pass buffer correctly to write()
    
    ../../source4/torture/basic/denytest.c: In function ‘torture_createx_specific.isra’:
    ../../source4/torture/basic/denytest.c:2372:9: error: ‘write’ reading 56 bytes from a region of size 8 [-Werror=stringop-overflow=]
     2372 |   res = write(data_file_fd, &cxd, cxd_len);
          |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14555
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Alexander Bokovoy <ab at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Wed Oct 28 17:52:19 UTC 2020 on sn-devel-184

-----------------------------------------------------------------------

Summary of changes:
 source4/torture/basic/denytest.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


Changeset truncated at 500 lines:

diff --git a/source4/torture/basic/denytest.c b/source4/torture/basic/denytest.c
index 1c946b81b92..8e7a822df09 100644
--- a/source4/torture/basic/denytest.c
+++ b/source4/torture/basic/denytest.c
@@ -2369,7 +2369,7 @@ static bool torture_createx_specific(struct torture_context *tctx, struct
 	if (data_file_fd >= 0) {
 		size_t cxd_len = sizeof(struct createx_data);
 		found = true;
-		res = write(data_file_fd, &cxd, cxd_len);
+		res = write(data_file_fd, cxd, cxd_len);
 		if (res != cxd_len) {
 			torture_result(tctx, TORTURE_FAIL,
 				"(%s): write failed: %s!",


-- 
Samba Shared Repository



More information about the samba-cvs mailing list