[SCM] Samba Shared Repository - branch master updated

Matthias Dieter Wallnöfer mdw at samba.org
Mon Sep 12 15:50:01 MDT 2011


The branch, master has been updated
       via  d0df757 s4:lib/socket/interface.c - "ifaces" strictly needs to be initialised
      from  fad5e3b Move the talloc_move call until *after* the check on status. Don't want to move something that might be invalid.

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -----------------------------------------------------------------
commit d0df75701e529e2d872691f8be047c5b55118930
Author: Matthias Dieter Wallnöfer <mdw at samba.org>
Date:   Mon Sep 12 15:45:11 2011 +0200

    s4:lib/socket/interface.c - "ifaces" strictly needs to be initialised
    
    Please consider a failing "get_interfaces" call and the "talloc_free()"
    operation on a possible uninitialised "ifaces" on line 326.
    
    https://bugzilla.samba.org/show_bug.cgi?id=8397
    
    Reviewed-by: Jelmer
    
    Autobuild-User: Matthias Dieter Wallnöfer <mdw at samba.org>
    Autobuild-Date: Mon Sep 12 23:49:12 CEST 2011 on sn-devel-104

-----------------------------------------------------------------------

Summary of changes:
 source4/lib/socket/interface.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source4/lib/socket/interface.c b/source4/lib/socket/interface.c
index 42e1946..7994716 100644
--- a/source4/lib/socket/interface.c
+++ b/source4/lib/socket/interface.c
@@ -293,7 +293,7 @@ void load_interface_list(TALLOC_CTX *mem_ctx, struct loadparm_context *lp_ctx, s
 {
 	const char **ptr = lpcfg_interfaces(lp_ctx);
 	int i;
-	struct iface_struct *ifaces;
+	struct iface_struct *ifaces = NULL;
 	int total_probed;
 	bool enable_ipv6 = lpcfg_parm_bool(lp_ctx, NULL, "ipv6", "enable", true);
 


-- 
Samba Shared Repository


More information about the samba-cvs mailing list