[SCM] Samba Shared Repository - branch master updated

Jelmer Vernooij jelmer at samba.org
Mon Sep 12 19:52:03 MDT 2011


The branch, master has been updated
       via  0ee22a2 s4-python: Fix some formatting issues.
       via  df1d3dc s4-python: Consistently use spaces rather than tabs, fix headers in several places.
       via  b4c4a2d Add samba.tests.source, which checks Python files for copyright lines, license headers and invalid characters (dos newlines, tabs).
       via  762102f testparm.py: Use standard formatting of header.
       via  62670d4 group.py: Remove tab characters.
       via  375a92c drs.py: Remove tab characters.
       via  4c7acab domain.py: Remove tab characters.
       via  dc26067 delegation.py: Remove tab characters.
       via  1fcce6b drs_utils.py: Remove tab characters.
      from  d0df757 s4:lib/socket/interface.c - "ifaces" strictly needs to be initialised

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -----------------------------------------------------------------
commit 0ee22a2dec1716e0d5c0a6aee612f635800af5ef
Author: Jelmer Vernooij <jelmer at samba.org>
Date:   Tue Sep 13 01:27:50 2011 +0200

    s4-python: Fix some formatting issues.
    
    Autobuild-User: Jelmer Vernooij <jelmer at samba.org>
    Autobuild-Date: Tue Sep 13 03:51:13 CEST 2011 on sn-devel-104

commit df1d3dc777b48bc9bc10f3eb44dec90db490a899
Author: Jelmer Vernooij <jelmer at samba.org>
Date:   Tue Sep 13 01:10:37 2011 +0200

    s4-python: Consistently use spaces rather than tabs, fix headers in several places.

commit b4c4a2d0f95166a8c3c01b8837103630fdea8c3f
Author: Jelmer Vernooij <jelmer at samba.org>
Date:   Tue Sep 13 01:09:16 2011 +0200

    Add samba.tests.source, which checks Python files for copyright lines, license headers and invalid characters (dos newlines, tabs).

commit 762102f05443165577495afc0f15c7a83d78b503
Author: Jelmer Vernooij <jelmer at samba.org>
Date:   Tue Sep 13 00:20:57 2011 +0200

    testparm.py: Use standard formatting of header.

commit 62670d43b81de0f9603b18e020687dfff129a9f9
Author: Jelmer Vernooij <jelmer at samba.org>
Date:   Tue Sep 13 00:20:17 2011 +0200

    group.py: Remove tab characters.

commit 375a92c302f0cc6b171358e4e954836e3eae1e91
Author: Jelmer Vernooij <jelmer at samba.org>
Date:   Tue Sep 13 00:20:03 2011 +0200

    drs.py: Remove tab characters.

commit 4c7acab5fc700c53381b52edd430c9c319b6ea50
Author: Jelmer Vernooij <jelmer at samba.org>
Date:   Tue Sep 13 00:19:51 2011 +0200

    domain.py: Remove tab characters.

commit dc26067a6f73d20fda65cc2996a0c6c156d4d5b0
Author: Jelmer Vernooij <jelmer at samba.org>
Date:   Tue Sep 13 00:19:45 2011 +0200

    delegation.py: Remove tab characters.

commit 1fcce6bd3f8bebbec02d2b0e9ef07da74d74f514
Author: Jelmer Vernooij <jelmer at samba.org>
Date:   Tue Sep 13 00:19:24 2011 +0200

    drs_utils.py: Remove tab characters.

-----------------------------------------------------------------------

Summary of changes:
 source4/librpc/rpc/dcerpc.py                       |    6 +-
 source4/scripting/bin/samba-tool                   |    2 +-
 source4/scripting/python/samba/__init__.py         |    5 +-
 source4/scripting/python/samba/drs_utils.py        |   18 +-
 source4/scripting/python/samba/getopt.py           |   23 +-
 source4/scripting/python/samba/ms_schema.py        |   19 +-
 source4/scripting/python/samba/ndr.py              |    2 +-
 .../scripting/python/samba/netcmd/delegation.py    |    4 +-
 source4/scripting/python/samba/netcmd/domain.py    |   25 +-
 source4/scripting/python/samba/netcmd/drs.py       |   72 +++---
 source4/scripting/python/samba/netcmd/group.py     |    4 +-
 source4/scripting/python/samba/netcmd/testparm.py  |   24 +-
 source4/scripting/python/samba/sd_utils.py         |    4 +-
 source4/scripting/python/samba/tests/auth.py       |    6 +-
 .../python/samba/tests/blackbox/__init__.py        |   16 +
 .../python/samba/tests/blackbox/ndrdump.py         |   14 +
 source4/scripting/python/samba/tests/core.py       |    6 +-
 .../scripting/python/samba/tests/credentials.py    |    6 +-
 .../python/samba/tests/dcerpc/__init__.py          |    2 +-
 .../scripting/python/samba/tests/dcerpc/bare.py    |    6 +-
 .../scripting/python/samba/tests/dcerpc/misc.py    |    6 +-
 .../python/samba/tests/dcerpc/registry.py          |    6 +-
 .../python/samba/tests/dcerpc/rpc_talloc.py        |   16 +-
 .../scripting/python/samba/tests/dcerpc/rpcecho.py |    6 +-
 source4/scripting/python/samba/tests/dcerpc/sam.py |    6 +-
 .../scripting/python/samba/tests/dcerpc/testrpc.py |   15 +-
 .../scripting/python/samba/tests/dcerpc/unix.py    |    6 +-
 source4/scripting/python/samba/tests/hostconfig.py |    6 +-
 source4/scripting/python/samba/tests/messaging.py  |    6 +-
 source4/scripting/python/samba/tests/provision.py  |    6 +-
 source4/scripting/python/samba/tests/registry.py   |    6 +-
 source4/scripting/python/samba/tests/samba3.py     |   13 +-
 source4/scripting/python/samba/tests/samba3sam.py  |    6 +-
 source4/scripting/python/samba/tests/source.py     |  168 ++++++++++
 source4/scripting/python/samba/tests/strings.py    |   20 +-
 .../scripting/python/samba/tests/unicodenames.py   |   22 +-
 source4/scripting/python/samba/tests/upgrade.py    |    6 +-
 source4/scripting/python/samba/upgrade.py          |   59 +++--
 source4/selftest/tests.py                          |    1 +
 source4/setup/provision                            |  319 ++++++++++----------
 40 files changed, 615 insertions(+), 348 deletions(-)
 create mode 100644 source4/scripting/python/samba/tests/source.py


Changeset truncated at 500 lines:

diff --git a/source4/librpc/rpc/dcerpc.py b/source4/librpc/rpc/dcerpc.py
index 7ce423b..73db9e3 100644
--- a/source4/librpc/rpc/dcerpc.py
+++ b/source4/librpc/rpc/dcerpc.py
@@ -2,17 +2,17 @@
 
 # Unix SMB/CIFS implementation.
 # Copyright (C) Jelmer Vernooij <jelmer at samba.org> 2008
-#   
+#
 # This program is free software; you can redistribute it and/or modify
 # it under the terms of the GNU General Public License as published by
 # the Free Software Foundation; either version 3 of the License, or
 # (at your option) any later version.
-#   
+#
 # This program is distributed in the hope that it will be useful,
 # but WITHOUT ANY WARRANTY; without even the implied warranty of
 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 # GNU General Public License for more details.
-#   
+#
 # You should have received a copy of the GNU General Public License
 # along with this program.  If not, see <http://www.gnu.org/licenses/>.
 #
diff --git a/source4/scripting/bin/samba-tool b/source4/scripting/bin/samba-tool
index c191865..f05fa3c 100755
--- a/source4/scripting/bin/samba-tool
+++ b/source4/scripting/bin/samba-tool
@@ -78,7 +78,7 @@ if __name__ == '__main__':
     try:
         retval = cmd._run("samba-tool", subcommand, *args)
     except SystemExit, e:
-	retval = -1
+        retval = -1
     except Exception, e:
         cmd.show_command_error(e)
     sys.exit(retval)
diff --git a/source4/scripting/python/samba/__init__.py b/source4/scripting/python/samba/__init__.py
index 03ee6fa..d81a25c 100644
--- a/source4/scripting/python/samba/__init__.py
+++ b/source4/scripting/python/samba/__init__.py
@@ -29,7 +29,7 @@ import sys
 import samba.param
 
 def source_tree_topdir():
-    '''return the top level directory (the one containing the source4 directory)'''
+    """Return the top level source directory."""
     paths = [ "../../..", "../../../.." ]
     for p in paths:
         topdir = os.path.normpath(os.path.join(os.path.dirname(__file__), p))
@@ -38,7 +38,7 @@ def source_tree_topdir():
     raise RuntimeError("unable to find top level source directory")
 
 def in_source_tree():
-    '''return True if we are running from within the samba source tree'''
+    """Return True if we are running from within the samba source tree"""
     try:
         topdir = source_tree_topdir()
     except RuntimeError:
@@ -46,7 +46,6 @@ def in_source_tree():
     return True
 
 
-
 import ldb
 from samba._ldb import Ldb as _Ldb
 
diff --git a/source4/scripting/python/samba/drs_utils.py b/source4/scripting/python/samba/drs_utils.py
index 80128ca..fbcbf2f 100644
--- a/source4/scripting/python/samba/drs_utils.py
+++ b/source4/scripting/python/samba/drs_utils.py
@@ -139,14 +139,14 @@ class drs_Replicate:
                 req8.replica_flags |= drsuapi.DRSUAPI_DRS_SPECIAL_SECRET_PROCESSING
             else:
                 req8.replica_flags |= drsuapi.DRSUAPI_DRS_WRIT_REP
-        req8.max_object_count		     = 402
-        req8.max_ndr_size		     = 402116
-        req8.extended_op		     = exop
-        req8.fsmo_info			     = 0
-        req8.partial_attribute_set	     = None
-        req8.partial_attribute_set_ex	     = None
-        req8.mapping_ctr.num_mappings	     = 0
-        req8.mapping_ctr.mappings	     = None
+        req8.max_object_count = 402
+        req8.max_ndr_size = 402116
+        req8.extended_op = exop
+        req8.fsmo_info = 0
+        req8.partial_attribute_set = None
+        req8.partial_attribute_set_ex = None
+        req8.mapping_ctr.num_mappings = 0
+        req8.mapping_ctr.mappings = None
 
         if not schema and rodc:
             req8.partial_attribute_set = self.drs_get_rodc_partial_attribute_set()
@@ -168,7 +168,7 @@ class drs_Replicate:
             if ctr.first_object == None and ctr.object_count != 0:
                 raise RuntimeError("DsGetNCChanges: NULL first_object with object_count=%u" % (ctr.object_count))
             self.net.replicate_chunk(self.replication_state, level, ctr,
-				     schema=schema, req_level=req_level, req=req)
+                schema=schema, req_level=req_level, req=req)
             if ctr.more_data == 0:
                 break
             req.highwatermark.tmp_highest_usn = ctr.new_highwatermark.tmp_highest_usn
diff --git a/source4/scripting/python/samba/getopt.py b/source4/scripting/python/samba/getopt.py
index 671142b..0ab1e9e 100644
--- a/source4/scripting/python/samba/getopt.py
+++ b/source4/scripting/python/samba/getopt.py
@@ -21,7 +21,8 @@
 
 __docformat__ = "restructuredText"
 
-import optparse, os
+import optparse
+import os
 from samba.credentials import (
     Credentials,
     DONT_USE_KERBEROS,
@@ -44,7 +45,8 @@ class SambaOptions(optparse.OptionGroup):
                         type=int, metavar="DEBUGLEVEL", help="debug level",
                         callback=self._set_debuglevel)
         self.add_option("--option", action="callback",
-                        type=str, metavar="OPTION", help="set smb.conf option from command line",
+                        type=str, metavar="OPTION",
+                        help="set smb.conf option from command line",
                         callback=self._set_option)
         self.add_option("--realm", action="callback",
                         type=str, metavar="REALM", help="set the realm name",
@@ -53,7 +55,7 @@ class SambaOptions(optparse.OptionGroup):
         self._lp = LoadParm()
 
     def get_loadparm_path(self):
-        """Return the path to the smb.conf file specified on the command line.  """
+        """Return path to the smb.conf file specified on the command line."""
         return self._configfile
 
     def _load_configfile(self, option, opt_str, arg, parser):
@@ -73,7 +75,7 @@ class SambaOptions(optparse.OptionGroup):
         self._lp.set(a[0], a[1])
 
     def get_loadparm(self):
-        """Return a loadparm object with data specified on the command line.  """
+        """Return loadparm object with data specified on the command line."""
         if self._configfile is not None:
             self._lp.load(self._configfile)
         elif os.getenv("SMB_CONF_PATH") is not None:
@@ -124,7 +126,8 @@ class CredentialsOptions(optparse.OptionGroup):
                         help="Use Kerberos", callback=self._set_kerberos)
         self.add_option("", "--ipaddress", metavar="IPADDRESS",
                         action="callback", type=str,
-                        help="IP address of server", callback=self._set_ipaddress)
+                        help="IP address of server",
+                        callback=self._set_ipaddress)
         self.creds = Credentials()
 
     def _parse_username(self, option, opt_str, arg, parser):
@@ -171,6 +174,7 @@ class CredentialsOptions(optparse.OptionGroup):
 
         return self.creds
 
+
 class CredentialsOptionsDouble(CredentialsOptions):
     """Command line options for specifying credentials of two servers."""
     def __init__(self, parser):
@@ -180,13 +184,16 @@ class CredentialsOptionsDouble(CredentialsOptions):
                         callback=self._set_simple_bind_dn2, type=str,
                         help="DN to use for a simple bind")
         self.add_option("--password2", metavar="PASSWORD2", action="callback",
-                        help="Password", type=str, callback=self._set_password2)
+                        help="Password", type=str,
+                        callback=self._set_password2)
         self.add_option("--username2", metavar="USERNAME2",
                         action="callback", type=str,
-                        help="Username for second server", callback=self._parse_username2)
+                        help="Username for second server",
+                        callback=self._parse_username2)
         self.add_option("--workgroup2", metavar="WORKGROUP2",
                         action="callback", type=str,
-                        help="Workgroup for second server", callback=self._parse_workgroup2)
+                        help="Workgroup for second server",
+                        callback=self._parse_workgroup2)
         self.add_option("--no-pass2", action="store_true",
                         help="Don't ask for a password for the second server")
         self.add_option("--kerberos2", metavar="KERBEROS2",
diff --git a/source4/scripting/python/samba/ms_schema.py b/source4/scripting/python/samba/ms_schema.py
index 64bb28a..6f7cc67 100644
--- a/source4/scripting/python/samba/ms_schema.py
+++ b/source4/scripting/python/samba/ms_schema.py
@@ -1,8 +1,19 @@
-#
 # create schema.ldif (as a string) from WSPP documentation
 #
 # based on minschema.py and minschema_wspp
 #
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 3 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
 """Generate LDIF from WSPP documentation."""
 
@@ -207,14 +218,14 @@ def __transform_entry(entry, objectClass):
 
         if not cn and key == "cn":
             cn = l[1]
-        
+
         if key in multivalued_attrs:
             # unlike LDIF, these are comma-separated
             l[1] = l[1].replace("\n ", "")
             l[1] = l[1].replace(" ", "")
 
             l[1] = l[1].split(",")
-            
+
         if key in bitFields:
             l[1] = __convert_bitfield(key, l[1])
 
@@ -275,5 +286,5 @@ if __name__ == '__main__':
     except IndexError:
         print >>sys.stderr, "Usage: %s attr-file.txt classes-file.txt" % (sys.argv[0])
         sys.exit(1)
-        
+
     print read_ms_schema(attr_file, classes_file)
diff --git a/source4/scripting/python/samba/ndr.py b/source4/scripting/python/samba/ndr.py
index 1126685..ccab112 100644
--- a/source4/scripting/python/samba/ndr.py
+++ b/source4/scripting/python/samba/ndr.py
@@ -23,7 +23,7 @@
 
 def ndr_pack(object):
     """Pack a NDR object.
-    
+
     :param object: Object to pack
     :return: String object with marshalled object.
     """
diff --git a/source4/scripting/python/samba/netcmd/delegation.py b/source4/scripting/python/samba/netcmd/delegation.py
index cf04d9d..c29c798 100644
--- a/source4/scripting/python/samba/netcmd/delegation.py
+++ b/source4/scripting/python/samba/netcmd/delegation.py
@@ -107,7 +107,7 @@ class cmd_delegation_for_any_service(Command):
         # to the correct domain
         (cleanedaccount, realm, domain) = _get_user_realm_domain(accountname)
 
-	search_filter = "sAMAccountName=%s" % ldb.binary_encode(cleanedaccount)
+        search_filter = "sAMAccountName=%s" % ldb.binary_encode(cleanedaccount)
         flag = dsdb.UF_TRUSTED_FOR_DELEGATION
         try:
             sam.toggle_userAccountFlags(search_filter, flag, on=on, strict=True)
@@ -142,7 +142,7 @@ class cmd_delegation_for_any_protocol(Command):
         # to the correct domain
         (cleanedaccount, realm, domain) = _get_user_realm_domain(accountname)
 
-	search_filter = "sAMAccountName=%s" % ldb.binary_encode(cleanedaccount)
+        search_filter = "sAMAccountName=%s" % ldb.binary_encode(cleanedaccount)
         flag = dsdb.UF_TRUSTED_TO_AUTHENTICATE_FOR_DELEGATION
         try:
             sam.toggle_userAccountFlags(search_filter, flag, on=on, strict=True)
diff --git a/source4/scripting/python/samba/netcmd/domain.py b/source4/scripting/python/samba/netcmd/domain.py
index c311748..b8f5561 100644
--- a/source4/scripting/python/samba/netcmd/domain.py
+++ b/source4/scripting/python/samba/netcmd/domain.py
@@ -568,9 +568,9 @@ samba3 testparm utility (with --testparm)."""
         logger = logging.getLogger("upgrade")
         logger.addHandler(logging.StreamHandler(sys.stdout))
         if quiet:
-        	logger.setLevel(logging.WARNING)
+            logger.setLevel(logging.WARNING)
         else:
-        	logger.setLevel(logging.INFO)
+            logger.setLevel(logging.INFO)
 
         lp = sambaopts.get_loadparm()
         realm = lp.get("realm")
@@ -582,17 +582,18 @@ samba3 testparm utility (with --testparm)."""
 
         eadb = True
         if use_xattrs == "yes":
-        	eadb = False
+            eadb = False
         elif use_xattrs == "auto" and not s3conf.get("posix:eadb"):
-        	tmpfile = tempfile.NamedTemporaryFile()
-    	try:
-    		samba.ntacls.setntacl(lp, tmpfile.name,
-    			"O:S-1-5-32G:S-1-5-32", "S-1-5-32", "native")
-    		eadb = False
-    	except:
-    		logger.info("You are not root or your system do not support xattr, using tdb backend for attributes. "
-			    "If you intend to use this provision in production, rerun the script as root on a system supporting xattrs.")
-    	tmpfile.close()
+            tmpfile = tempfile.NamedTemporaryFile()
+            try:
+                samba.ntacls.setntacl(lp, tmpfile.name,
+                            "O:S-1-5-32G:S-1-5-32", "S-1-5-32", "native")
+                eadb = False
+            except:
+                # FIXME: Don't catch all exceptions here
+                logger.info("You are not root or your system do not support xattr, using tdb backend for attributes. "
+                            "If you intend to use this provision in production, rerun the script as root on a system supporting xattrs.")
+            tmpfile.close()
 
         # Set correct default values from libdir or testparm
         paths = {}
diff --git a/source4/scripting/python/samba/netcmd/drs.py b/source4/scripting/python/samba/netcmd/drs.py
index f652504..e7a3cbf 100644
--- a/source4/scripting/python/samba/netcmd/drs.py
+++ b/source4/scripting/python/samba/netcmd/drs.py
@@ -360,46 +360,46 @@ class cmd_drs_bind(Command):
         (info, handle) = self.drsuapi.DsBind(misc.GUID(drsuapi.DRSUAPI_DS_BIND_GUID), bind_info)
 
         optmap = [
-            ("DRSUAPI_SUPPORTED_EXTENSION_BASE" ,  			"DRS_EXT_BASE"),
-            ("DRSUAPI_SUPPORTED_EXTENSION_ASYNC_REPLICATION" ,  	"DRS_EXT_ASYNCREPL"),
-            ("DRSUAPI_SUPPORTED_EXTENSION_REMOVEAPI" ,  		"DRS_EXT_REMOVEAPI"),
-            ("DRSUAPI_SUPPORTED_EXTENSION_MOVEREQ_V2" , 		"DRS_EXT_MOVEREQ_V2"),
-            ("DRSUAPI_SUPPORTED_EXTENSION_GETCHG_COMPRESS" , 		"DRS_EXT_GETCHG_DEFLATE"),
-            ("DRSUAPI_SUPPORTED_EXTENSION_DCINFO_V1" , 			"DRS_EXT_DCINFO_V1"),
-            ("DRSUAPI_SUPPORTED_EXTENSION_RESTORE_USN_OPTIMIZATION" ,  	"DRS_EXT_RESTORE_USN_OPTIMIZATION"),
-            ("DRSUAPI_SUPPORTED_EXTENSION_ADDENTRY" , 			"DRS_EXT_ADDENTRY"),
-            ("DRSUAPI_SUPPORTED_EXTENSION_KCC_EXECUTE" , 		"DRS_EXT_KCC_EXECUTE"),
-            ("DRSUAPI_SUPPORTED_EXTENSION_ADDENTRY_V2" , 		"DRS_EXT_ADDENTRY_V2"),
-            ("DRSUAPI_SUPPORTED_EXTENSION_LINKED_VALUE_REPLICATION" ,  	"DRS_EXT_LINKED_VALUE_REPLICATION"),
-            ("DRSUAPI_SUPPORTED_EXTENSION_DCINFO_V2" , 			"DRS_EXT_DCINFO_V2"),
+            ("DRSUAPI_SUPPORTED_EXTENSION_BASE",     "DRS_EXT_BASE"),
+            ("DRSUAPI_SUPPORTED_EXTENSION_ASYNC_REPLICATION",   "DRS_EXT_ASYNCREPL"),
+            ("DRSUAPI_SUPPORTED_EXTENSION_REMOVEAPI",    "DRS_EXT_REMOVEAPI"),
+            ("DRSUAPI_SUPPORTED_EXTENSION_MOVEREQ_V2",   "DRS_EXT_MOVEREQ_V2"),
+            ("DRSUAPI_SUPPORTED_EXTENSION_GETCHG_COMPRESS",   "DRS_EXT_GETCHG_DEFLATE"),
+            ("DRSUAPI_SUPPORTED_EXTENSION_DCINFO_V1",    "DRS_EXT_DCINFO_V1"),
+            ("DRSUAPI_SUPPORTED_EXTENSION_RESTORE_USN_OPTIMIZATION",   "DRS_EXT_RESTORE_USN_OPTIMIZATION"),
+            ("DRSUAPI_SUPPORTED_EXTENSION_ADDENTRY",    "DRS_EXT_ADDENTRY"),
+            ("DRSUAPI_SUPPORTED_EXTENSION_KCC_EXECUTE",   "DRS_EXT_KCC_EXECUTE"),
+            ("DRSUAPI_SUPPORTED_EXTENSION_ADDENTRY_V2",   "DRS_EXT_ADDENTRY_V2"),
+            ("DRSUAPI_SUPPORTED_EXTENSION_LINKED_VALUE_REPLICATION",   "DRS_EXT_LINKED_VALUE_REPLICATION"),
+            ("DRSUAPI_SUPPORTED_EXTENSION_DCINFO_V2",    "DRS_EXT_DCINFO_V2"),
             ("DRSUAPI_SUPPORTED_EXTENSION_INSTANCE_TYPE_NOT_REQ_ON_MOD","DRS_EXT_INSTANCE_TYPE_NOT_REQ_ON_MOD"),
-            ("DRSUAPI_SUPPORTED_EXTENSION_CRYPTO_BIND" , 		"DRS_EXT_CRYPTO_BIND"),
-            ("DRSUAPI_SUPPORTED_EXTENSION_GET_REPL_INFO" , 		"DRS_EXT_GET_REPL_INFO"),
-            ("DRSUAPI_SUPPORTED_EXTENSION_STRONG_ENCRYPTION" , 		"DRS_EXT_STRONG_ENCRYPTION"),
-            ("DRSUAPI_SUPPORTED_EXTENSION_DCINFO_V01" , 		"DRS_EXT_DCINFO_VFFFFFFFF"),
-            ("DRSUAPI_SUPPORTED_EXTENSION_TRANSITIVE_MEMBERSHIP" , 	"DRS_EXT_TRANSITIVE_MEMBERSHIP"),
-            ("DRSUAPI_SUPPORTED_EXTENSION_ADD_SID_HISTORY" , 		"DRS_EXT_ADD_SID_HISTORY"),
-            ("DRSUAPI_SUPPORTED_EXTENSION_POST_BETA3" , 		"DRS_EXT_POST_BETA3"),
-            ("DRSUAPI_SUPPORTED_EXTENSION_GETCHGREQ_V5" , 		"DRS_EXT_GETCHGREQ_V5"),
-            ("DRSUAPI_SUPPORTED_EXTENSION_GET_MEMBERSHIPS2" , 		"DRS_EXT_GETMEMBERSHIPS2"),
-            ("DRSUAPI_SUPPORTED_EXTENSION_GETCHGREQ_V6" , 		"DRS_EXT_GETCHGREQ_V6"),
-            ("DRSUAPI_SUPPORTED_EXTENSION_NONDOMAIN_NCS" , 		"DRS_EXT_NONDOMAIN_NCS"),
-            ("DRSUAPI_SUPPORTED_EXTENSION_GETCHGREQ_V8" , 		"DRS_EXT_GETCHGREQ_V8"),
-            ("DRSUAPI_SUPPORTED_EXTENSION_GETCHGREPLY_V5" , 		"DRS_EXT_GETCHGREPLY_V5"),
-            ("DRSUAPI_SUPPORTED_EXTENSION_GETCHGREPLY_V6" , 		"DRS_EXT_GETCHGREPLY_V6"),
-            ("DRSUAPI_SUPPORTED_EXTENSION_ADDENTRYREPLY_V3" , 		"DRS_EXT_WHISTLER_BETA3"),
-            ("DRSUAPI_SUPPORTED_EXTENSION_GETCHGREPLY_V7" , 		"DRS_EXT_WHISTLER_BETA3"),
-            ("DRSUAPI_SUPPORTED_EXTENSION_VERIFY_OBJECT" , 		"DRS_EXT_WHISTLER_BETA3"),
-            ("DRSUAPI_SUPPORTED_EXTENSION_XPRESS_COMPRESS" , 		"DRS_EXT_W2K3_DEFLATE"),
-            ("DRSUAPI_SUPPORTED_EXTENSION_GETCHGREQ_V10" , 		"DRS_EXT_GETCHGREQ_V10"),
-            ("DRSUAPI_SUPPORTED_EXTENSION_RESERVED_PART2" , 		"DRS_EXT_RESERVED_FOR_WIN2K_OR_DOTNET_PART2"),
-            ("DRSUAPI_SUPPORTED_EXTENSION_RESERVED_PART3" , 		"DRS_EXT_RESERVED_FOR_WIN2K_OR_DOTNET_PART3")
+            ("DRSUAPI_SUPPORTED_EXTENSION_CRYPTO_BIND",   "DRS_EXT_CRYPTO_BIND"),
+            ("DRSUAPI_SUPPORTED_EXTENSION_GET_REPL_INFO",   "DRS_EXT_GET_REPL_INFO"),
+            ("DRSUAPI_SUPPORTED_EXTENSION_STRONG_ENCRYPTION",   "DRS_EXT_STRONG_ENCRYPTION"),
+            ("DRSUAPI_SUPPORTED_EXTENSION_DCINFO_V01",   "DRS_EXT_DCINFO_VFFFFFFFF"),
+            ("DRSUAPI_SUPPORTED_EXTENSION_TRANSITIVE_MEMBERSHIP",  "DRS_EXT_TRANSITIVE_MEMBERSHIP"),
+            ("DRSUAPI_SUPPORTED_EXTENSION_ADD_SID_HISTORY",   "DRS_EXT_ADD_SID_HISTORY"),
+            ("DRSUAPI_SUPPORTED_EXTENSION_POST_BETA3",   "DRS_EXT_POST_BETA3"),
+            ("DRSUAPI_SUPPORTED_EXTENSION_GETCHGREQ_V5",   "DRS_EXT_GETCHGREQ_V5"),
+            ("DRSUAPI_SUPPORTED_EXTENSION_GET_MEMBERSHIPS2",   "DRS_EXT_GETMEMBERSHIPS2"),
+            ("DRSUAPI_SUPPORTED_EXTENSION_GETCHGREQ_V6",   "DRS_EXT_GETCHGREQ_V6"),
+            ("DRSUAPI_SUPPORTED_EXTENSION_NONDOMAIN_NCS",   "DRS_EXT_NONDOMAIN_NCS"),
+            ("DRSUAPI_SUPPORTED_EXTENSION_GETCHGREQ_V8",   "DRS_EXT_GETCHGREQ_V8"),
+            ("DRSUAPI_SUPPORTED_EXTENSION_GETCHGREPLY_V5",   "DRS_EXT_GETCHGREPLY_V5"),
+            ("DRSUAPI_SUPPORTED_EXTENSION_GETCHGREPLY_V6",   "DRS_EXT_GETCHGREPLY_V6"),
+            ("DRSUAPI_SUPPORTED_EXTENSION_ADDENTRYREPLY_V3",   "DRS_EXT_WHISTLER_BETA3"),
+            ("DRSUAPI_SUPPORTED_EXTENSION_GETCHGREPLY_V7",   "DRS_EXT_WHISTLER_BETA3"),
+            ("DRSUAPI_SUPPORTED_EXTENSION_VERIFY_OBJECT",   "DRS_EXT_WHISTLER_BETA3"),
+            ("DRSUAPI_SUPPORTED_EXTENSION_XPRESS_COMPRESS",   "DRS_EXT_W2K3_DEFLATE"),
+            ("DRSUAPI_SUPPORTED_EXTENSION_GETCHGREQ_V10",   "DRS_EXT_GETCHGREQ_V10"),
+            ("DRSUAPI_SUPPORTED_EXTENSION_RESERVED_PART2",   "DRS_EXT_RESERVED_FOR_WIN2K_OR_DOTNET_PART2"),
+            ("DRSUAPI_SUPPORTED_EXTENSION_RESERVED_PART3", "DRS_EXT_RESERVED_FOR_WIN2K_OR_DOTNET_PART3")
             ]
 
         optmap_ext = [
-            ("DRSUAPI_SUPPORTED_EXTENSION_ADAM",			"DRS_EXT_ADAM"),
-            ("DRSUAPI_SUPPORTED_EXTENSION_LH_BETA2",			"DRS_EXT_LH_BETA2"),
-            ("DRSUAPI_SUPPORTED_EXTENSION_RECYCLE_BIN",			"DRS_EXT_RECYCLE_BIN")]
+            ("DRSUAPI_SUPPORTED_EXTENSION_ADAM", "DRS_EXT_ADAM"),
+            ("DRSUAPI_SUPPORTED_EXTENSION_LH_BETA2", "DRS_EXT_LH_BETA2"),
+            ("DRSUAPI_SUPPORTED_EXTENSION_RECYCLE_BIN", "DRS_EXT_RECYCLE_BIN")]
 
         self.message("Bind to %s succeeded." % DC)
         self.message("Extensions supported:")
diff --git a/source4/scripting/python/samba/netcmd/group.py b/source4/scripting/python/samba/netcmd/group.py
index 5540a52..90bee5f 100644
--- a/source4/scripting/python/samba/netcmd/group.py
+++ b/source4/scripting/python/samba/netcmd/group.py
@@ -49,8 +49,8 @@ class cmd_group_add(Command):
         Option("-H", "--URL", help="LDB URL for database or target server", type=str,
                metavar="URL", dest="H"),
         Option("--groupou",
-	   help="Alternative location (without domainDN counterpart) to default CN=Users in which new user object will be created",
-	   type=str),
+           help="Alternative location (without domainDN counterpart) to default CN=Users in which new user object will be created",
+           type=str),
         Option("--group-scope", type="choice", choices=["Domain", "Global", "Universal"],
             help="Group scope (Domain | Global | Universal)"),
         Option("--group-type", type="choice", choices=["Security", "Distribution"],
diff --git a/source4/scripting/python/samba/netcmd/testparm.py b/source4/scripting/python/samba/netcmd/testparm.py
index 3e4f520..53d6d80 100755
--- a/source4/scripting/python/samba/netcmd/testparm.py
+++ b/source4/scripting/python/samba/netcmd/testparm.py
@@ -11,18 +11,18 @@
 #   Updated for Samba4 by Andrew Bartlett <abartlet at samba.org> 2006
 #   Converted to Python by Jelmer Vernooij <jelmer at samba.org> 2010
 #
-#   This program is free software; you can redistribute it and/or modify
-#   it under the terms of the GNU General Public License as published by
-#   the Free Software Foundation; either version 3 of the License, or
-#   (at your option) any later version.
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 3 of the License, or
+# (at your option) any later version.
 #
-#   This program is distributed in the hope that it will be useful,
-#   but WITHOUT ANY WARRANTY; without even the implied warranty of
-#   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-#   GNU General Public License for more details.
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
 #
-#   You should have received a copy of the GNU General Public License
-#   along with this program.  If not, see <http://www.gnu.org/licenses/>.
+# You should have received a copy of the GNU General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
 #
 # Testbed for loadparm.c/params.c
 #
diff --git a/source4/scripting/python/samba/sd_utils.py b/source4/scripting/python/samba/sd_utils.py
index ea8f2e7..66ff6cc 100644
--- a/source4/scripting/python/samba/sd_utils.py
+++ b/source4/scripting/python/samba/sd_utils.py
@@ -26,6 +26,7 @@ from ldb import FLAG_MOD_REPLACE, SCOPE_BASE
 from samba.ndr import ndr_pack, ndr_unpack
 from samba.dcerpc import security
 
+
 class SDUtils(object):
     """Some utilities for manipulation of security descriptors
     on objects"""
@@ -69,7 +70,8 @@ class SDUtils(object):
         if ace in desc_sddl:
             return
         if desc_sddl.find("(") >= 0:
-            desc_sddl = desc_sddl[:desc_sddl.index("(")] + ace + desc_sddl[desc_sddl.index("("):]
+            desc_sddl = (desc_sddl[:desc_sddl.index("(")] + ace +
+                         desc_sddl[desc_sddl.index("("):])
         else:
             desc_sddl = desc_sddl + ace
         self.modify_sd_on_dn(object_dn, desc_sddl)
diff --git a/source4/scripting/python/samba/tests/auth.py b/source4/scripting/python/samba/tests/auth.py
index 6ecfc20..8c87d91 100644
--- a/source4/scripting/python/samba/tests/auth.py
+++ b/source4/scripting/python/samba/tests/auth.py
@@ -2,17 +2,17 @@
 
 # Unix SMB/CIFS implementation.
 # Copyright (C) Jelmer Vernooij <jelmer at samba.org> 2007
-#   
+#
 # This program is free software; you can redistribute it and/or modify
 # it under the terms of the GNU General Public License as published by
 # the Free Software Foundation; either version 3 of the License, or
 # (at your option) any later version.
-#   
+#
 # This program is distributed in the hope that it will be useful,
 # but WITHOUT ANY WARRANTY; without even the implied warranty of
 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 # GNU General Public License for more details.
-#   
+#
 # You should have received a copy of the GNU General Public License
 # along with this program.  If not, see <http://www.gnu.org/licenses/>.
 #
diff --git a/source4/scripting/python/samba/tests/blackbox/__init__.py b/source4/scripting/python/samba/tests/blackbox/__init__.py
index 8569cb5..361e5cf 100644
--- a/source4/scripting/python/samba/tests/blackbox/__init__.py
+++ b/source4/scripting/python/samba/tests/blackbox/__init__.py
@@ -1 +1,17 @@


-- 
Samba Shared Repository


More information about the samba-cvs mailing list