[SCM] Samba Shared Repository - branch master updated - release-4-0-0alpha8-25-gd9eb1d9

Jeremy Allison jra at samba.org
Fri Jun 19 23:45:10 GMT 2009


The branch, master has been updated
       via  d9eb1d9764a27ae63c8d7f13d7f4148fd1833753 (commit)
      from  f262f80a1c7c9206c028abe9e2157b1dc955333b (commit)

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -----------------------------------------------------------------
commit d9eb1d9764a27ae63c8d7f13d7f4148fd1833753
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Jun 19 16:44:15 2009 -0700

    Fix coverity #900. Resource leak.
    Jeremy.

-----------------------------------------------------------------------

Summary of changes:
 source3/utils/smbpasswd.c |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source3/utils/smbpasswd.c b/source3/utils/smbpasswd.c
index c0b2cac..7957dd8 100644
--- a/source3/utils/smbpasswd.c
+++ b/source3/utils/smbpasswd.c
@@ -398,6 +398,10 @@ static int process_root(int local_flags)
 
 		if (remote_machine != NULL) {
 			old_passwd = get_pass("Old SMB password:",stdin_passwd_get);
+			if(!old_passwd) {
+				fprintf(stderr, "Unable to get old password.\n");
+				exit(1);
+			}
 		}
 
 		if (!(local_flags & LOCAL_SET_PASSWORD)) {
@@ -478,6 +482,7 @@ static int process_root(int local_flags)
 	}
 
  done:
+	SAFE_FREE(old_passwd);
 	SAFE_FREE(new_passwd);
 	return result;
 }


-- 
Samba Shared Repository


More information about the samba-cvs mailing list