[SCM] Samba Shared Repository - branch master updated - release-4-0-0alpha8-24-gf262f80

Jeremy Allison jra at samba.org
Fri Jun 19 22:30:32 GMT 2009


The branch, master has been updated
       via  f262f80a1c7c9206c028abe9e2157b1dc955333b (commit)
      from  1e989dbb91175a6e040117ac77bcd58fba877605 (commit)

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -----------------------------------------------------------------
commit f262f80a1c7c9206c028abe9e2157b1dc955333b
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Jun 19 15:29:35 2009 -0700

    Fix coverity #920. Possible NULL deref.
    Jeremy.

-----------------------------------------------------------------------

Summary of changes:
 source3/utils/pdbedit.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source3/utils/pdbedit.c b/source3/utils/pdbedit.c
index 23c4e71..a464299 100644
--- a/source3/utils/pdbedit.c
+++ b/source3/utils/pdbedit.c
@@ -708,6 +708,10 @@ static int new_user(const char *username, const char *fullname,
 
 	pwd1 = get_pass( "new password:", stdin_get);
 	pwd2 = get_pass( "retype new password:", stdin_get);
+	if (!pwd1 || !pwd2) {
+		fprintf(stderr, "Failed to read passwords.\n");
+		return -1;
+	}
 	ret = strcmp(pwd1, pwd2);
 	if (ret != 0) {
 		fprintf (stderr, "Passwords do not match!\n");


-- 
Samba Shared Repository


More information about the samba-cvs mailing list