[SCM] Samba Shared Repository - branch master updated - release-4-0-0alpha6-835-g147a2e3

[Volker Lendecke]

The branch, master has been updated
       via  147a2e3440056ec30d8b386901754a58ea3947d1 (commit)
      from  d75fe9b3934d9c8e0c2bbeb8d0a27deb0b2eb58a (commit)

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -----------------------------------------------------------------
commit 147a2e3440056ec30d8b386901754a58ea3947d1
Author: Volker Lendecke <vl at samba.org>
Date:   Thu Feb 12 23:19:45 2009 +0100

    Fix Coverity ID 871 -- do not dereference "sp" before checking for NULL

-----------------------------------------------------------------------

Summary of changes:
 source4/lib/socket/socket_ip.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source4/lib/socket/socket_ip.c b/source4/lib/socket/socket_ip.c
index cdb75fe..89b310a 100644
--- a/source4/lib/socket/socket_ip.c
+++ b/source4/lib/socket/socket_ip.c
@@ -552,11 +552,13 @@ static struct in6_addr interpret_addr6(const char *name)
 	char addr[INET6_ADDRSTRLEN];
 	struct in6_addr dest6;
 	const char *sp = name;
-	char *p = strchr_m(sp, '%');
+	char *p;
 	int ret;
 
 	if (sp == NULL) return in6addr_any;
 
+	p = strchr_m(sp, '%');
+
 	if (strcasecmp(sp, "localhost") == 0) {
 		sp = "::1";
 	}


-- 
Samba Shared Repository