[SCM] Samba Shared Repository - branch master updated - release-4-0-0alpha6-834-gd75fe9b

Volker Lendecke vlendec at samba.org
Thu Feb 12 22:18:01 GMT 2009


The branch, master has been updated
       via  d75fe9b3934d9c8e0c2bbeb8d0a27deb0b2eb58a (commit)
      from  dc19a60e50b89886f98541ad227e6f3a3bc8720b (commit)

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -----------------------------------------------------------------
commit d75fe9b3934d9c8e0c2bbeb8d0a27deb0b2eb58a
Author: Volker Lendecke <vl at samba.org>
Date:   Thu Feb 12 23:16:18 2009 +0100

    Fix Coverity ID 872 -- we have alread dereferenced "ac" 2 lines above

-----------------------------------------------------------------------

Summary of changes:
 source4/lib/ldb/modules/sort.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source4/lib/ldb/modules/sort.c b/source4/lib/ldb/modules/sort.c
index 2b2a1ab..309101c 100644
--- a/source4/lib/ldb/modules/sort.c
+++ b/source4/lib/ldb/modules/sort.c
@@ -108,7 +108,7 @@ static int sort_compare(struct ldb_message **msg1, struct ldb_message **msg2, vo
 
 	ldb = ldb_module_get_ctx(ac->module);
 
-	if (!ac || ac->sort_result != 0) {
+	if (ac->sort_result != 0) {
 		/* an error occurred previously,
 		 * let's exit the sorting by returning always 0 */
 		return 0;


-- 
Samba Shared Repository


More information about the samba-cvs mailing list