[SCM] Samba Shared Repository - branch v3-3-test updated -
release-3-2-0pre2-5213-g9a28b28
Michael Adam
obnox at samba.org
Thu Apr 16 08:39:01 GMT 2009
The branch, v3-3-test has been updated
via 9a28b28314c6a76cf619fc5f1b676d1f4229e3e1 (commit)
from 597be402e40ff880b595ae49a8600b932365cbcb (commit)
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-3-test
- Log -----------------------------------------------------------------
commit 9a28b28314c6a76cf619fc5f1b676d1f4229e3e1
Author: Martin Schwenke <martin at meltin.net>
Date: Thu Apr 16 10:25:29 2009 +1000
In net_conf_import, start a transaction when importing a single share.
Commit d69c3db9d44ad5d9fd1f5d7a9499f3bd79ecfb47 caused the transaction
start to be conditional but the commit is still unconditional, so an
error occurs when importing a single share.
An alternate fix would be to return the transaction start to be
unconditional but then it would occur before other error checking.
Signed-off-by: Martin Schwenke <martin at meltin.net>
Signed-off-by: Michael Adam <obnox at samba.org>
-----------------------------------------------------------------------
Summary of changes:
source/utils/net_conf.c | 8 ++++++++
1 files changed, 8 insertions(+), 0 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source/utils/net_conf.c b/source/utils/net_conf.c
index dea6209..f6e3712 100644
--- a/source/utils/net_conf.c
+++ b/source/utils/net_conf.c
@@ -340,6 +340,14 @@ static int net_conf_import(struct net_context *c, struct smbconf_ctx *conf_ctx,
if (!W_ERROR_IS_OK(werr)) {
goto cancel;
}
+
+ werr = smbconf_transaction_start(conf_ctx);
+ if (!W_ERROR_IS_OK(werr)) {
+ d_printf("error starting transaction: %s\n",
+ dos_errstr(werr));
+ goto done;
+ }
+
werr = import_process_service(c, conf_ctx, service);
if (!W_ERROR_IS_OK(werr)) {
goto cancel;
--
Samba Shared Repository
More information about the samba-cvs
mailing list