[SCM] SAMBA-CTDB repository - branch v3-2-ctdb updated - build_3.2.10_ctdb.58-2-g9b5be0d

Michael Adam obnox at samba.org
Thu Apr 16 08:38:37 GMT 2009


The branch, v3-2-ctdb has been updated
       via  9b5be0d38099deb117e9fca996bf032f35904079 (commit)
      from  ec14ef17bb9c601438354ff94d68f76cdc71ea0e (commit)

http://gitweb.samba.org/?p=obnox/samba-ctdb.git;a=shortlog;h=v3-2-ctdb


- Log -----------------------------------------------------------------
commit 9b5be0d38099deb117e9fca996bf032f35904079
Author: Martin Schwenke <martin at meltin.net>
Date:   Thu Apr 16 10:25:29 2009 +1000

    In net_conf_import, start a transaction when importing a single share.
    
    Commit d69c3db9d44ad5d9fd1f5d7a9499f3bd79ecfb47 caused the transaction
    start to be conditional but the commit is still unconditional, so an
    error occurs when importing a single share.
    
    An alternate fix would be to return the transaction start to be
    unconditional but then it would occur before other error checking.
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Signed-off-by: Michael Adam <obnox at samba.org>

-----------------------------------------------------------------------

Summary of changes:
 source/utils/net_conf.c |    8 ++++++++
 1 files changed, 8 insertions(+), 0 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source/utils/net_conf.c b/source/utils/net_conf.c
index 86fea14..57b9d51 100644
--- a/source/utils/net_conf.c
+++ b/source/utils/net_conf.c
@@ -323,6 +323,14 @@ static int net_conf_import(struct smbconf_ctx *conf_ctx,
 		if (!W_ERROR_IS_OK(werr)) {
 			goto cancel;
 		}
+
+		werr = smbconf_transaction_start(conf_ctx);
+		if (!W_ERROR_IS_OK(werr)) {
+			d_printf("error starting transaction: %s\n",
+				 dos_errstr(werr));
+			goto done;
+		}
+
 		werr = import_process_service(conf_ctx, service);
 		if (!W_ERROR_IS_OK(werr)) {
 			goto cancel;


-- 
SAMBA-CTDB repository


More information about the samba-cvs mailing list