[SCM] Samba Shared Repository - branch master updated - 97d57d03640664416500efb1f1cf8e5a4a9522d8

Jeremy Allison jra at samba.org
Tue Sep 30 20:28:19 GMT 2008


The branch, master has been updated
       via  97d57d03640664416500efb1f1cf8e5a4a9522d8 (commit)
      from  f84093df863eb00238a6be1caba59d926f18e7a5 (commit)

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -----------------------------------------------------------------
commit 97d57d03640664416500efb1f1cf8e5a4a9522d8
Author: Jeremy Allison <jra at samba.org>
Date:   Tue Sep 30 13:26:41 2008 -0700

    Fix the make test problem Karolin reported. Now rename_open_files actually works correctly we must emit the change notify before we change the name, not before.
    Jeremy.

-----------------------------------------------------------------------

Summary of changes:
 source3/smbd/reply.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source3/smbd/reply.c b/source3/smbd/reply.c
index 6933533..8bfa28f 100644
--- a/source3/smbd/reply.c
+++ b/source3/smbd/reply.c
@@ -5583,10 +5583,10 @@ NTSTATUS rename_internals_fsp(connection_struct *conn,
 		DEBUG(3,("rename_internals_fsp: succeeded doing rename on %s -> %s\n",
 			fsp->fsp_name,newname));
 
-		rename_open_files(conn, lck, newname);
-
 		notify_rename(conn, fsp->is_directory, fsp->fsp_name, newname);
 
+		rename_open_files(conn, lck, newname);
+
 		/*
 		 * A rename acts as a new file create w.r.t. allowing an initial delete
 		 * on close, probably because in Windows there is a new handle to the


-- 
Samba Shared Repository


More information about the samba-cvs mailing list