[SCM] Samba Shared Repository - branch v3-2-test updated - release-3-2-0pre2-3058-g10ae99d

Jeremy Allison jra at samba.org
Tue Sep 30 20:33:17 GMT 2008


The branch, v3-2-test has been updated
       via  10ae99d86c0c90bee9a0538854f6f96fc7cbbc23 (commit)
      from  41898a42c1ad7d382088799a6e3f712583808d20 (commit)

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-2-test


- Log -----------------------------------------------------------------
commit 10ae99d86c0c90bee9a0538854f6f96fc7cbbc23
Author: Jeremy Allison <jra at samba.org>
Date:   Tue Sep 30 13:21:27 2008 -0700

    Fix the make test problem Karolin reported. Now rename_open_files actually works correctly we must emit the change notify before we change the name, not before.
    Jeremy.

-----------------------------------------------------------------------

Summary of changes:
 source/smbd/reply.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source/smbd/reply.c b/source/smbd/reply.c
index 466fef9..2d271ab 100644
--- a/source/smbd/reply.c
+++ b/source/smbd/reply.c
@@ -5556,10 +5556,10 @@ NTSTATUS rename_internals_fsp(connection_struct *conn,
 		DEBUG(3,("rename_internals_fsp: succeeded doing rename on %s -> %s\n",
 			fsp->fsp_name,newname));
 
-		rename_open_files(conn, lck, newname);
-
 		notify_rename(conn, fsp->is_directory, fsp->fsp_name, newname);
 
+		rename_open_files(conn, lck, newname);
+
 		/*
 		 * A rename acts as a new file create w.r.t. allowing an initial delete
 		 * on close, probably because in Windows there is a new handle to the


-- 
Samba Shared Repository


More information about the samba-cvs mailing list