[SCM] Samba Shared Repository - branch v3-0-test updated -
release-3-0-29-83-gdd78195
Michael Adam
obnox at samba.org
Tue Jul 8 14:18:50 GMT 2008
The branch, v3-0-test has been updated
via dd781951fb9acc556f1bd6760b72151a7c359a9f (commit)
from a56de3ce7051deed5f36b03186bccac6ea0d2ce4 (commit)
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-0-test
- Log -----------------------------------------------------------------
commit dd781951fb9acc556f1bd6760b72151a7c359a9f
Author: Michael Adam <obnox at samba.org>
Date: Tue Jul 8 16:13:24 2008 +0200
tdbtool: fix off-by-one error in argument length. (bug #2344)
This prevented all commands operating on keys (all non-traverse commands)
in tdbtool to fail with a "fetch failed" or "delete failed" message.
It seems that it fixes bug #2344 ...
Apparently this bug was introduced with 94e53472666ed in 2005.
Either nobody is using tdbtool or else tdb_find() has become
more strict about the key legth in the meantime. :-)
Michael
-----------------------------------------------------------------------
Summary of changes:
source/tdb/tools/tdbtool.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source/tdb/tools/tdbtool.c b/source/tdb/tools/tdbtool.c
index 4bddf76..9592c39 100644
--- a/source/tdb/tools/tdbtool.c
+++ b/source/tdb/tools/tdbtool.c
@@ -633,7 +633,7 @@ static char *convert_string(char *instring, size_t *sizep)
}
length++;
}
- *sizep = length;
+ *sizep = length + 1;
return instring;
}
--
Samba Shared Repository
More information about the samba-cvs
mailing list