[SCM] Samba Shared Repository - branch v3-2-test updated - release-3-2-0pre2-2691-g6df9df2

Michael Adam obnox at samba.org
Tue Jul 8 14:06:03 GMT 2008


The branch, v3-2-test has been updated
       via  6df9df2f340040eda81c241ce1f03207572d23e5 (commit)
      from  c1baf310830e7ebff4fe0835812122ec146412da (commit)

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-2-test


- Log -----------------------------------------------------------------
commit 6df9df2f340040eda81c241ce1f03207572d23e5
Author: Michael Adam <obnox at samba.org>
Date:   Tue Jul 8 15:33:36 2008 +0200

    tdbtool: fix off-by-one error in argument length. (bug #2344)
    
    This prevented all commands operating on keys (all non-traverse commands)
    in tdbtool to fail with a "fetch failed" or "delete failed" message.
    
    It seems that it fixes bug #2344 ...
    
    Apparently this bug was introduced with 94e53472666ed in 2005.
    Either nobody is using tdbtool or else tdb_find() has become
    more strict about the key legth in the meantime. :-)
    
    Michael
    (cherry picked from commit fafb8ad2b81b9a46cf8259bedc1dca5023b06115)

-----------------------------------------------------------------------

Summary of changes:
 source/lib/tdb/tools/tdbtool.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source/lib/tdb/tools/tdbtool.c b/source/lib/tdb/tools/tdbtool.c
index d104ccd..500e441 100644
--- a/source/lib/tdb/tools/tdbtool.c
+++ b/source/lib/tdb/tools/tdbtool.c
@@ -598,7 +598,7 @@ static char *convert_string(char *instring, size_t *sizep)
 	}
 	length++;
     }
-    *sizep = length;
+    *sizep = length + 1;
     return instring;
 }
 


-- 
Samba Shared Repository


More information about the samba-cvs mailing list