svn commit: samba r14118 - in branches/SAMBA_3_0/source/libads: .

jra at samba.org jra at samba.org
Thu Mar 9 22:49:39 GMT 2006


Author: jra
Date: 2006-03-09 22:49:38 +0000 (Thu, 09 Mar 2006)
New Revision: 14118

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=14118

Log:
Fix coverity bug #24. Missing return statement meant
a possible NULL ptr deref.
Jeremy.

Modified:
   branches/SAMBA_3_0/source/libads/ldap.c


Changeset:
Modified: branches/SAMBA_3_0/source/libads/ldap.c
===================================================================
--- branches/SAMBA_3_0/source/libads/ldap.c	2006-03-09 22:48:33 UTC (rev 14117)
+++ branches/SAMBA_3_0/source/libads/ldap.c	2006-03-09 22:49:38 UTC (rev 14118)
@@ -2692,7 +2692,7 @@
 	asprintf(&expr, "(&(objectclass=computer)(dnshostname=%s.%s))", 
 		 ads->config.ldap_server_name, ads->config.realm);
 	if (expr == NULL) {
-		ADS_ERROR_NT(NT_STATUS_NO_MEMORY);
+		return ADS_ERROR_NT(NT_STATUS_NO_MEMORY);
 	}
 
 	rc = ads_search(ads, &res, expr, attrs);



More information about the samba-cvs mailing list