svn commit: samba r14119 - in trunk/source/libads: .

jra at samba.org jra at samba.org
Thu Mar 9 22:49:46 GMT 2006


Author: jra
Date: 2006-03-09 22:49:44 +0000 (Thu, 09 Mar 2006)
New Revision: 14119

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=14119

Log:
Fix coverity bug #24. Missing return statement meant
a possible NULL ptr deref.
Jeremy.

Modified:
   trunk/source/libads/ldap.c


Changeset:
Modified: trunk/source/libads/ldap.c
===================================================================
--- trunk/source/libads/ldap.c	2006-03-09 22:49:38 UTC (rev 14118)
+++ trunk/source/libads/ldap.c	2006-03-09 22:49:44 UTC (rev 14119)
@@ -2692,7 +2692,7 @@
 	asprintf(&expr, "(&(objectclass=computer)(dnshostname=%s.%s))", 
 		 ads->config.ldap_server_name, ads->config.realm);
 	if (expr == NULL) {
-		ADS_ERROR_NT(NT_STATUS_NO_MEMORY);
+		return ADS_ERROR_NT(NT_STATUS_NO_MEMORY);
 	}
 
 	rc = ads_search(ads, &res, expr, attrs);



More information about the samba-cvs mailing list