svn commit: samba r16382 - in trunk/source/passdb: .

jra at samba.org jra at samba.org
Tue Jun 20 01:02:58 GMT 2006


Author: jra
Date: 2006-06-20 01:02:58 +0000 (Tue, 20 Jun 2006)
New Revision: 16382

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=16382

Log:
Klocwork #1086. No null deref.
Jeremy.

Modified:
   trunk/source/passdb/pdb_interface.c


Changeset:
Modified: trunk/source/passdb/pdb_interface.c
===================================================================
--- trunk/source/passdb/pdb_interface.c	2006-06-20 01:00:39 UTC (rev 16381)
+++ trunk/source/passdb/pdb_interface.c	2006-06-20 01:02:58 UTC (rev 16382)
@@ -1479,6 +1479,11 @@
 
 		unbecome_root();		/* -----> EXIT BECOME_ROOT() */
 		*name = talloc_strdup(mem_ctx, pdb_get_username(sam_account));
+		if (!*name) {
+			TALLOC_FREE(sam_account);
+			return False;
+		}
+
 		*psid_name_use = SID_NAME_USER;
 
 		TALLOC_FREE(sam_account);



More information about the samba-cvs mailing list