svn commit: samba r16383 - in branches/SAMBA_3_0/source/passdb: .

jra at samba.org jra at samba.org
Tue Jun 20 01:03:05 GMT 2006


Author: jra
Date: 2006-06-20 01:03:04 +0000 (Tue, 20 Jun 2006)
New Revision: 16383

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=16383

Log:
Klocwork #1086. No null deref.
Jeremy.

Modified:
   branches/SAMBA_3_0/source/passdb/pdb_interface.c


Changeset:
Modified: branches/SAMBA_3_0/source/passdb/pdb_interface.c
===================================================================
--- branches/SAMBA_3_0/source/passdb/pdb_interface.c	2006-06-20 01:02:58 UTC (rev 16382)
+++ branches/SAMBA_3_0/source/passdb/pdb_interface.c	2006-06-20 01:03:04 UTC (rev 16383)
@@ -1470,6 +1470,11 @@
 
 		unbecome_root();		/* -----> EXIT BECOME_ROOT() */
 		*name = talloc_strdup(mem_ctx, pdb_get_username(sam_account));
+		if (!*name) {
+			TALLOC_FREE(sam_account);
+			return False;
+		}
+
 		*psid_name_use = SID_NAME_USER;
 
 		TALLOC_FREE(sam_account);



More information about the samba-cvs mailing list