svn commit: samba r17866 - in branches: SAMBA_3_0/source/lib SAMBA_3_0_23/source/lib

jra at samba.org jra at samba.org
Mon Aug 28 02:27:50 GMT 2006


Author: jra
Date: 2006-08-28 02:27:49 +0000 (Mon, 28 Aug 2006)
New Revision: 17866

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=17866

Log:
Fix possible null deref - found by Stanford checker.
Jeremy.

Modified:
   branches/SAMBA_3_0/source/lib/util_str.c
   branches/SAMBA_3_0_23/source/lib/util_str.c


Changeset:
Modified: branches/SAMBA_3_0/source/lib/util_str.c
===================================================================
--- branches/SAMBA_3_0/source/lib/util_str.c	2006-08-28 02:24:15 UTC (rev 17865)
+++ branches/SAMBA_3_0/source/lib/util_str.c	2006-08-28 02:27:49 UTC (rev 17866)
@@ -2056,7 +2056,7 @@
 	int i;
 	
 	/* arguments checking */
-	if (!ip_list && !ipstr_list) return 0;
+	if (!ip_list || !ipstr_list) return 0;
 
 	*ipstr_list = NULL;
 	

Modified: branches/SAMBA_3_0_23/source/lib/util_str.c
===================================================================
--- branches/SAMBA_3_0_23/source/lib/util_str.c	2006-08-28 02:24:15 UTC (rev 17865)
+++ branches/SAMBA_3_0_23/source/lib/util_str.c	2006-08-28 02:27:49 UTC (rev 17866)
@@ -2023,7 +2023,7 @@
 	int i;
 	
 	/* arguments checking */
-	if (!ip_list && !ipstr_list) return 0;
+	if (!ip_list || !ipstr_list) return 0;
 
 	*ipstr_list = NULL;
 	



More information about the samba-cvs mailing list