svn commit: samba r17867 - in branches: SAMBA_3_0/source/registry SAMBA_3_0_23/source/registry

[jra at samba.org]

Author: jra
Date: 2006-08-28 02:29:36 +0000 (Mon, 28 Aug 2006)
New Revision: 17867

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=17867

Log:
Fix null deref in error code path. Found by the
Stanford checker.
Jeremy.

Modified:
   branches/SAMBA_3_0/source/registry/reg_objects.c
   branches/SAMBA_3_0_23/source/registry/reg_objects.c


Changeset:
Modified: branches/SAMBA_3_0/source/registry/reg_objects.c
===================================================================
--- branches/SAMBA_3_0/source/registry/reg_objects.c	2006-08-28 02:27:49 UTC (rev 17866)
+++ branches/SAMBA_3_0/source/registry/reg_objects.c	2006-08-28 02:29:36 UTC (rev 17867)
@@ -182,6 +182,7 @@
 			DEBUG(0,("dup_registry_value: memdup() failed for [%d] bytes!\n",
 				val->size));
 			SAFE_FREE( copy );
+			return NULL;
 		}
 		copy->size = val->size;
 	}

Modified: branches/SAMBA_3_0_23/source/registry/reg_objects.c
===================================================================
--- branches/SAMBA_3_0_23/source/registry/reg_objects.c	2006-08-28 02:27:49 UTC (rev 17866)
+++ branches/SAMBA_3_0_23/source/registry/reg_objects.c	2006-08-28 02:29:36 UTC (rev 17867)
@@ -181,6 +181,7 @@
 			DEBUG(0,("dup_registry_value: memdup() failed for [%d] bytes!\n",
 				val->size));
 			SAFE_FREE( copy );
+			return NULL;
 		}
 		copy->size = val->size;
 	}