svn commit: samba r11732 - in branches/SAMBA_3_0/source/lib: .
jra at samba.org
jra at samba.org
Tue Nov 15 18:54:34 GMT 2005
Author: jra
Date: 2005-11-15 18:54:33 +0000 (Tue, 15 Nov 2005)
New Revision: 11732
WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=11732
Log:
Remember to return early if -1 returned from *BSD EA call.
Pointed out by timur at com.bat.ru.
Jeremy.
Modified:
branches/SAMBA_3_0/source/lib/system.c
Changeset:
Modified: branches/SAMBA_3_0/source/lib/system.c
===================================================================
--- branches/SAMBA_3_0/source/lib/system.c 2005-11-15 05:28:30 UTC (rev 11731)
+++ branches/SAMBA_3_0/source/lib/system.c 2005-11-15 18:54:33 UTC (rev 11732)
@@ -1387,6 +1387,10 @@
*/
retval = extattr_get_file(path, attrnamespace, attrname, NULL, 0);
+ if (retval == -1) {
+ return -1;
+ }
+
if(retval > size) {
errno = ERANGE;
return -1;
@@ -1422,6 +1426,10 @@
retval = extattr_get_link(path, attrnamespace, attrname, NULL, 0);
+ if (retval == -1) {
+ return -1;
+ }
+
if(retval > size) {
errno = ERANGE;
return -1;
@@ -1457,6 +1465,10 @@
retval = extattr_get_fd(filedes, attrnamespace, attrname, NULL, 0);
+ if (retval == -1) {
+ return -1;
+ }
+
if(retval > size) {
errno = ERANGE;
return -1;
More information about the samba-cvs
mailing list