svn commit: samba r11733 - in trunk/source/lib: .

[jra at samba.org]

Author: jra
Date: 2005-11-15 18:54:36 +0000 (Tue, 15 Nov 2005)
New Revision: 11733

WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=11733

Log:
Remember to return early if -1 returned from *BSD EA call.
Pointed out by timur at com.bat.ru.
Jeremy.

Modified:
   trunk/source/lib/system.c


Changeset:
Modified: trunk/source/lib/system.c
===================================================================
--- trunk/source/lib/system.c	2005-11-15 18:54:33 UTC (rev 11732)
+++ trunk/source/lib/system.c	2005-11-15 18:54:36 UTC (rev 11733)
@@ -1387,6 +1387,10 @@
 	 */
 	retval = extattr_get_file(path, attrnamespace, attrname, NULL, 0);
 
+	if (retval == -1) {
+		return -1;
+	}
+
 	if(retval > size) {
 		errno = ERANGE;
 		return -1;
@@ -1422,6 +1426,10 @@
 
 	retval = extattr_get_link(path, attrnamespace, attrname, NULL, 0);
 
+	if (retval == -1) {
+		return -1;
+	}
+
 	if(retval > size) {
 		errno = ERANGE;
 		return -1;
@@ -1457,6 +1465,10 @@
 
 	retval = extattr_get_fd(filedes, attrnamespace, attrname, NULL, 0);
 
+	if (retval == -1) {
+		return -1;
+	}
+
 	if(retval > size) {
 		errno = ERANGE;
 		return -1;