CVS update: samba/source/smbd

[jra at dp.samba.org]

On Sun, Dec 01, 2002 at 04:18:33PM +1100, Andrew Bartlett wrote:
> 
> I just double-checked it, and as long as that STR_TERMINATE does it's
> job, the most we will encounter is a strequal() or a Get_Pwnam(). (for
> homes magic).  
> 
> However it might be a good idea to put a limit on the string size in
> make_connection() due to the complexity of our 'magic services'...

Yeah, that's what the original 'copy to fstring' was doing.
You know, I'd feel happier if you'd just revert this. Not
only does it have to be correct, it also has to *look*
correct - otherwise code auditors get nervous, and people
start worrying about our security policies and stance.

Please put back the fstring copy. Thanks,

Jeremy.