CVS update: samba/source/smbd

[Andrew Bartlett]

On Sun, 2002-12-01 at 14:58, jra at dp.samba.org wrote:
> On Sun, Dec 01, 2002 at 03:16:59AM +0000, abartlet at samba.org wrote:
> > 
> > Date:	Sun Dec  1 03:16:59 2002
> > Author:	abartlet
> > 
> > Update of /data/cvs/samba/source/smbd
> > In directory dp.samba.org:/tmp/cvs-serv29592/smbd
> > 
> > Modified Files:
> > 	reply.c 
> > Log Message:
> > No need for fstring manipulation here (Tcon&X), just use string pointers.
> 
> Just a hint on quick review of the patch.
> Be careful of using data direct from the client here.....

I just double-checked it, and as long as that STR_TERMINATE does it's
job, the most we will encounter is a strequal() or a Get_Pwnam(). (for
homes magic).  

However it might be a good idea to put a limit on the string size in
make_connection() due to the complexity of our 'magic services'...

> If you think it's good, please merge all these to 3.0.

Yep, just looking at all the other things I need to merge as well.

Andrew Bartlett

-- 
Andrew Bartlett                                 abartlet at pcug.org.au
Manager, Authentication Subsystems, Samba Team  abartlet at samba.org
Student Network Administrator, Hawker College   abartlet at hawkerc.net
http://samba.org     http://build.samba.org     http://hawkerc.net
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : http://lists.samba.org/archive/samba-cvs/attachments/20021201/ff3c908d/attachment.bin