CVS update: samba/source

[Andrew Bartlett]

Herb Lewis wrote:
> 
> Andrew Bartlett wrote:
> >
> > Herb Lewis wrote:
> > >
> > > Jean Francois Micouleau wrote:
> > > >
> > > > On Thu, 6 Dec 2001, Herb Lewis wrote:
> > > >
> > > > > WE NEED TO FIND A SOLUTION TO THIS!!! I have tried twice to fix this
> > > > > in different places and each time, someone reverts this. What is the
> > > > > intent of .headers.stamp???? If things are dependent on proto.h
> > > > > then they should be getting rebuilt!!!
> > > >
> > > > yes I agree. but when only 2 files are dependent on proto.h should the
> > > > whole tree be rebuild ?
> > > >
> > >
> > > Why do you say only 2 files are dependent? If a prototype changes
> > > then every file that uses that function needs to be compiled.
> >
> > Samba doesn't have proper dependencies.  Apparently this is a feature -
> > becouse we (apparently) don't want a 'make proto' to also force an
> > effective 'make clean'.
> 
> I agree things are broken with no easy fix. However, I still insist
> that a make clean should remove the .headers.stamp file otherwise
> from that point on every build rebuilds everything!!!!! You expect
> a make clean to cause everything to rebuild (that is the whole
> purpose of doing one so you don't have any junk left over) so it
> should remove .headers.stamp so it can also be rebuilt correctly.
> With the current target definition, if .headers.stamp exists at
> all it will never be updated.
> 
> I have tried 2 different fixes and someone always finds something
> wrong with them. Let's either remove make clean as a target since
> it is badly broken (which is a rediculous suggestion) or fix it
> so it works as expected. I think the proper solution is to have
> the clean target also remove .headers.stamp since it removes
> the files it depends on.

I belive this is the correct solution, if 'make clean' removes the
header files.

One of the arguments has been that 'make proto' should not need to be
executed by the builder, that we should ship a 'proto.h' file in the
distribution.  This is in some attempt to avoid the use of awk in the
build process.  (Note that you can't even run configure without sed).

Andrew Bartlett
-- 
Andrew Bartlett                                 abartlet at pcug.org.au
Manager, Authentication Subsystems, Samba Team  abartlet at samba.org
Student Network Administrator, Hawker College   abartlet at hawkerc.net
http://samba.org     http://build.samba.org     http://hawkerc.net