CVS update: samba/source

Herb Lewis herb at sgi.com
Fri Dec 7 09:08:10 EST 2001


Andrew Bartlett wrote:
> 
> Herb Lewis wrote:
> >
> > Jean Francois Micouleau wrote:
> > >
> > > On Thu, 6 Dec 2001, Herb Lewis wrote:
> > >
> > > > WE NEED TO FIND A SOLUTION TO THIS!!! I have tried twice to fix this
> > > > in different places and each time, someone reverts this. What is the
> > > > intent of .headers.stamp???? If things are dependent on proto.h
> > > > then they should be getting rebuilt!!!
> > >
> > > yes I agree. but when only 2 files are dependent on proto.h should the
> > > whole tree be rebuild ?
> > >
> >
> > Why do you say only 2 files are dependent? If a prototype changes
> > then every file that uses that function needs to be compiled.
> 
> Samba doesn't have proper dependencies.  Apparently this is a feature -
> becouse we (apparently) don't want a 'make proto' to also force an
> effective 'make clean'.

I agree things are broken with no easy fix. However, I still insist
that a make clean should remove the .headers.stamp file otherwise
from that point on every build rebuilds everything!!!!! You expect
a make clean to cause everything to rebuild (that is the whole
purpose of doing one so you don't have any junk left over) so it
should remove .headers.stamp so it can also be rebuilt correctly.
With the current target definition, if .headers.stamp exists at
all it will never be updated. 

I have tried 2 different fixes and someone always finds something
wrong with them. Let's either remove make clean as a target since
it is badly broken (which is a rediculous suggestion) or fix it
so it works as expected. I think the proper solution is to have
the clean target also remove .headers.stamp since it removes 
the files it depends on.

> 
> The problem is that all the prototypes are kept in one file - so a
> change to any one function definition would cause a full Samba rebuild
> (becouse *any* Samba module could have used it).
> 
> In any case this is how it is.  I'm all in favor of a proper build
> dependency system, if sombody cares to code it up.
> 
> Andrew Bartlett

-- 
======================================================================
Herb Lewis                               Silicon Graphics 
Networking Engineer                      1600 Amphitheatre Pkwy MS-510
Strategic Software Organization          Mountain View, CA  94043-1351
herb at sgi.com                             Tel: 650-933-2177
http://www.sgi.com                       Fax: 650-932-2177          
======================================================================




More information about the samba-cvs mailing list