CVS update: samba/source/lib

Luke Kenneth Casson Leighton lkcl at samba.org
Thu Mar 23 08:02:46 EST 2000


On Thu, 23 Mar 2000, Jeremy Allison wrote:

> Luke Kenneth Casson Leighton wrote:
> 
> > unapproved??
> > 
> > how about a code review of an unapproved patch from HP, i didn't see any
> > code reviews for it and i certainly didn't approve it.
> 
> It was not finished and it was in a branch in which you are *not*
> doing active development.
> 
> It was a "work in progress" patch and a placeholder for me to
> fixup, based on discussions I'd already had with the patch
> author.

jeremy, what got me mad was that you didn't involve me in those
discussions, i only found out that you were encouraging someone at HP to
take part in samba development from a patch that looks like it's going in
the wrong direction.

but i don't _know_ that, because i wasn't involved.

i don't like surprises like this, they tend to freak me out.

particularly as i have been trying to re-channel all development efforts
of cvs main code that are already developed in what is now TNG, as they
are a waste of _someone's_ time, and redirect those efforts into a single
area - the area that has had about three man-years of work put into it -
the area that you keep saying is "not good enough".


i have tried removing code, you put it back.

i have tried putting warning messages, you remove them.

i have tried disabling incorrect code, you re-enable it.


what do i have to do?  i think i just have to let you get on with this,
and let you find out things yourself.

luke



More information about the samba-cvs mailing list