CVS update: samba/source/lib

[Jeremy Allison]

Luke Kenneth Casson Leighton wrote:

> unapproved??
> 
> how about a code review of an unapproved patch from HP, i didn't see any
> code reviews for it and i certainly didn't approve it.

It was not finished and it was in a branch in which you are *not*
doing active development.

It was a "work in progress" patch and a placeholder for me to
fixup, based on discussions I'd already had with the patch
author.

Imagine I looked at every patch you put into TNG, and went
in an arbitrarily modified anything I didn't like.

How could you work in TNG under those circumstances ?

> large??  i restored the previous functionality.  i added an important
> comment that needs to be in there so that people don't waste their time
> making developments on two-year-old code.

The issue was you didn't ask. You need to learn respect
for the work that others are doing in different branches.

If you have an issue with a patch *check* with the person
who committed it first. There may be very good reasons
for it (there are in this case).

Note this code did *not* go into the 2.0.7 release tree
as it is certainly not production code and is not finished.

You jumped all over it without a second thought. That's
the real problem. Engage brain before typing.

I *never* do that in TNG. I read and learn from it. If
I have an issue (for example what looked like an error
in the ALIGN code) I  *asked* you as the author to explain
if my understanding is correct. Note that I didn't make
the change myself as you have primary responsibility
in this tree and I respect your judgement there.

This is called "playing nice" in a shared code tree.

Please do it in the other branches. A simple "I don't
understand this patch, it would seem to be incorrect"
would have saved much shouting and gnashing of teeth.

Jeremy.

-- 
--------------------------------------------------------
Buying an operating system without source is like buying
a self-assembly Space Shuttle with no instructions.
--------------------------------------------------------