CVS update: samba/source/libsmb

Luke Kenneth Casson Leighton lkcl at switchboard.net
Wed Jan 27 11:47:11 EST 1999


On Wed, 27 Jan 1999, Andrew Tridgell wrote:

> > Modified Files:
> > 	clientgen.c 
> 
> Luke,
> 
> Can you explain this change please? As far as I can tell you've
> totally removed support for encrypted passwords in
> cli_session_setup().

that's correct.

> You've left support for them in tconx which means
> it will work for share level security but not for user level security.
> You've removed support for NT hashes completely.

not quite.

when cli_establish_connection() is used, this function provides support
for clear-text, NULL and encrypted passwords through a password storing
struct.

there is only one instance where cli_session_setup is used with a
plain-text password that was expected to be encrypted inside
cli_session_setup, that was in smbwrapper/smbw.c.  i cut/paste the
SMBencrypt and SMBNTencrypt functions in cli_session_setup and placed them
prior to the cli_session_setup call inside the function that called
cli_session_setup.

all other instances of samba code that use cli_session_setup are used to:

- do NULL sessions

- do NT/LM 24 byte password encryptions themselves.

- call cli_establish_connection() which deals with passwords itself.

i mentioned but did not expand in detail that i had done this.

luke



More information about the samba-cvs mailing list