CVS update: samba/source/client
Tim Potter
tpot at acsys.anu.edu.au
Wed Jan 20 17:41:07 EST 1999
> > Modified Files:
> > Tag: SAMBA_2_0
> > client.c
> > Log Message:
> > Changed a number of ints to SMB_OFF_T. The transfer statistics printed
> > by smbclient for files >2GB were incorrect.
>
> Tim,
>
> I believe this change is incorrect. You have changed
> several cli_read() calls in client.c to use an SMB_OFF_T,
> but the parameter in libsmb/clientgen.c takes an off_t
> parameter - the two are *NOT* always equivalent.
I've changed the global variables get_total_size, put_total_size,
dir_total: these are only used in the generation of transfer statistics.
The nread local in do_put was extended to a OFF_T and is passed to
cli_read() - oops.
I'll back the change out, but I should point out that someone has already
converted the nread variable in the do_get() function to an OFF_T [fx: it
was like that when I got here!].
Tim.
>
> Cheers,
>
> Jeremy.
>
>
>
More information about the samba-cvs
mailing list