CVS update: samba/source/ubiqx
Christopher R. Hertel
crh at NTS.Umn.EDU
Fri May 22 14:56:03 EST 1998
You really didn't listen to anything I said last time 'round, did you?
I think you are very wrong about this, but I'm going to try some
work-arounds to make it work. The number one thing I'd warn against is
including the ubiqx headers in includes.h. The problem has to do with
conflicting macro redefinitions. I don't want the base BinTree module
calling SplayTree functions. I also don't want AVL redefinitions to
conflict with SplayTree redefinitions. Keep in mind that you and I and
Jeremy *have* talked about using similar redefinitions in other parts of
Samba. The ubiqx stuff is an example of the kind of coding we've talked
about using throughout.
...and that's why I think we should be talking about it instead of
code-changing wars. I really *don't* think you're giving me a fair
chance here. I have been very good about discussing changes with you
before making them.
For now, the work-around is to *not* include ubiqx headers in includes.h.
Another possibility is to create method structures (activation records?
what was it Borland used to call these?) so that the types are not mutex.
This is basically what I did with the database functions. It would be
quite a pain, though, and much less efficient.
On the other hand, since includes.h is not included in the ubiqx headers,
the ubiqx headers *must* be included *after* includes.h in the .c files.
This is what I've done. Please *do not* try to include includes.h in all
of the ubiqx headers until you've discussed it with me. I have some
other ideas that just might make everyone happy. I'd really like to have
the chance to explore them with you before more changes are made.
Trying to remain polite and calm...
> Date: Friday May 22, 1998 @ 10:32
> Author: tridge
> Update of /data/cvs/samba/source/ubiqx
> In directory samba:/tmp/cvs-serv12853
> Modified Files:
> Log Message:
> #ifdef HAVE_INCLUDES_H
> #include "../includes.h"
> we want _all_ code in Samba to include this file to ensure that we can
> override definitions, typedefs and includes in one place.
Christopher R. Hertel -)----- University of Minnesota
crh at nts.umn.edu Networking and Telecommunications Services
More information about the samba-cvs