CVS update: samba/source

Jeremy Allison jallison at
Wed May 20 09:53:33 EST 1998

Andrew Tridgell wrote:
> > util.c: Fix for multibyte characters in strlower, strupper and string_replace.
> We're going to have to split our string routines into two sets. Those
> functions are sometimes used on things that definately should not be
> treated as multi-byte strings (for example, the results of
> getpwuid). Also, should things that come from smb.conf be treated as
> multi-byte strings? I suspect not, but the main purpose of
> string_replace() is for such strings.

Well string_replace() is in fact *only* used for pathnames.
That's why I changed it :-).

> I think we need a set of string routines to deal with "normal"
> strings, and another set to deal with potentially multi-byte strings.

Probably we need a set of functions that can be multi-byte
for things transmitted over the wire, as it's really just 
strings that are sent to and from the client that need to
take account of different code page sets. This should be 
fixable (I'll take a look at it). For the moment I don't
think leaving the multibyte functions in strlower and
strupper will do harm, as it's only when an asian code
page is selected that any characters will be skipped.


Buying an operating system without source is like buying
a self-assembly Space Shuttle with no instructions.

More information about the samba-cvs mailing list