[Bug 13071] [PATCH] Allow --partial-dir with --inplace

samba-bugs at samba.org samba-bugs at samba.org
Wed Apr 29 23:56:31 UTC 2020


Wayne Davison <wayne at opencoder.net> changed:

           What    |Removed                     |Added
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED
            Version|3.1.3                       |3.2.0

--- Comment #9 from Wayne Davison <wayne at opencoder.net> ---
Yes, an absolute-path partial dir is not removed by rsync.  I'll add a mention
of that to the manpage.

I'm committing the simple version of the patch.  Thanks for checking it out!

As to the question about which basis file is better to use when a partial file
exists, that is indeed a hard one to answer since it depends a lot on how much
of a transfer completed and how much matching data exists in each file.  So far
I've left it up to the user to remove a partial file that would make their
transfer worse off, but it might be possible to come up with a simple heuristic
when creating the partial file to guess if we think we should save it or not --
something based on the partial file size vs final file size and also how much
of its data was copied literally vs copied from the current basis file.  That
seems like it would be pretty useful to me, especially if it erred on the side
of only removing the partial file if it was very clear it was not going to be

You are receiving this mail because:
You are the QA Contact for the bug.

More information about the rsync mailing list