[Bug 11668] New: incorrect/inconsistent behavior when --backup-dir is on a full filesystem

[samba-bugs at samba.org]

https://bugzilla.samba.org/show_bug.cgi?id=11668

            Bug ID: 11668
           Summary: incorrect/inconsistent behavior when --backup-dir is
                    on a full filesystem
           Product: rsync
           Version: 3.1.2
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5
         Component: core
          Assignee: wayned at samba.org
          Reporter: abezella at archive.org
        QA Contact: rsync-qa at samba.org

hello - we are having some issues w/the exit value of `rsync --backup` when
--backup-dir is on a full filesystem.

for instance:
* rsync  version 3.1.2  protocol version 31
* the filesystem mounted on /2 is 100% full, /1 has plenty of space

when the destination files exist but a delta needs to be transmitted, running:
> rsync -av --delete -b --backup-dir=/2/tmp rsync://instance0.us.archive.org/items_11/McGillLibrary-129621-5035 /1/2.1/.
results in:
> receiving incremental file list
> McGillLibrary-129621-5035/129621_scandata.xml
> rsync: backup mkdir /2/tmp/McGillLibrary-129621-5035 failed: No space left on device (28)
> 
> sent 164 bytes  received 1,333 bytes  2,994.00 bytes/sec
> total size is 26,763,596  speedup is 17,878.15
and an exit status of 0 despite the error.  the file-to-be-modified remains
unchanged, and the rsync tmpfile that is transferred over is left in place.

subsequent runs of the command also fail, but with an exit value of 23 (i'm
guessing because the make_backup reports failing as well as the "backup
mkdir"?):
> receiving incremental file list
> rsync: backup mkdir /2/tmp/McGillLibrary-129621-5035 failed: No space left on device (28)
> rsync: delete_file: make_backup(McGillLibrary-129621-5035/.129621_scandata.xml.nKW4Sg) failed: Success (0)
> McGillLibrary-129621-5035/129621_scandata.xml
> rsync: backup mkdir /2/tmp/McGillLibrary-129621-5035 failed: No space left on device (28)
> 
> sent 164 bytes  received 1,333 bytes  2,994.00 bytes/sec
> total size is 26,763,596  speedup is 17,878.15
> rsync error: some files/attrs were not transferred (see previous errors) (code 23) at main.c(1650) [generator=3.1.2]

i _believe_ that this behavior started in 3.1.0 (best recollection is that
3.0.9 did not suffer from this, although
https://lists.samba.org/archive/rsync/2013-July/028488.html looks like it may
be related).

thank you in advance for any help you can provide, and thanks for rsync! 
please let me know if there is additional information that may be useful or
further tests that can be run.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.