DO NOT REPLY [Bug 7194] New: Getting --inplace and --sparse to work together

[samba-bugs at samba.org]

https://bugzilla.samba.org/show_bug.cgi?id=7194

           Summary: Getting --inplace and --sparse to work together
           Product: rsync
           Version: 3.0.7
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: enhancement
          Priority: P3
         Component: core
        AssignedTo: wayned at samba.org
        ReportedBy: jansen at webgods.de
         QAContact: rsync-qa at samba.org


I created a small patch to get --inplace and --sparse to work together. The
main problem with this is, as far as I can see, that the write code just skips
blocks of zeroes instead of writing them, as is requested by the --sparse
switch. If the target already exists and has data in places where the source
has zeroes, this data will never get erased.
My patch simply reads these regions first and makes sure they really are zero.
If they are not, it clears them.
It would be good if someone with a deeper knowledge of the implications could
have a look at the patch to see if I missed something.


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.