DO NOT REPLY [Bug 5644] Option to recheck basis dirs for existing dest files

samba-bugs at samba.org samba-bugs at samba.org
Tue Sep 29 13:42:59 MDT 2009


https://bugzilla.samba.org/show_bug.cgi?id=5644


samba at bryanthansen.net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |samba at bryanthansen.net




------- Comment #5 from samba at bryanthansen.net  2009-09-29 14:42 CST -------
Here is a proposed patch for rsync 3.0.6 that implements this functionality.

There are no extra options, as proposed in some of the previous posts.  If a
"basis file" passes the unchanged_file() *and* the unchanged_attrs() tests, the
DEST file will be removed and replaced with a hard link to the basis file.

Note: unchanged_file() is the internal rsync test for checking file sizes,
times, and/or checksums when comparing files.  unchanged_attrs() checks
ownership, permissions, and ACL's.

Now the tricky part: in the case that a basis file passes the unchanged_file()
test, but not the unchanged_attrs() test, it's tempting to replace DEST with a
hardlink *if* the DEST fails the unchanged_file() test.  However, the danger is
that attributes & ACL's from the basis file would eventually be thrown away in
later rsync operations, since these basis file attributes are now coupled with
the DEST.


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.


More information about the rsync mailing list