[PATCH] Make progress output show "done" instead of "to-chk".
matt at mattmccutchen.net
Mon Nov 3 05:07:41 GMT 2008
On Sun, 2008-11-02 at 21:02 -0800, Wayne Davison wrote:
> On Wed, Oct 22, 2008 at 02:05:43AM -0400, Matt McCutchen wrote:
> > In incremental recursion mode, the number of files "to check" can
> > increase (when new file-list chunks are built) as well as decrease,
> > which I found confusing to watch. This patch makes the progress line
> > show the number of files "done" (which increases monotonically)
> > instead.
> I chose to display the to-check number because it is a more useful value
> to the user. It is easy to eye-ball with small transfers, but as the
> number of files increases, it becomes harder to mentally subtract the
> numbers to see how close we are to being done. Since an incremental
> transfer is increasing the number of total files as it finds new files
> to transfer, hopefully the user will see that it makes sense that the
> to-check value would also need to go up (even if they find it surprising
> at first).
I agree that the "to-chk" is more useful in non-incremental recursion
mode, but I would argue that it is completely meaningless if some
unknown number of files have yet to be scanned. Perhaps rsync could
show "done" in incremental recursion mode and "to-chk" otherwise.
If you still disagree, I suppose my proposal will go the way of the
"don't show a meaningless speedup on a dry run", i.e., I put it in my
custom version of rsync if I ever find the time to maintain one.
More information about the rsync