DO NOT REPLY [Bug 3653] Silence 'vanished files' messages

[samba-bugs at samba.org]

https://bugzilla.samba.org/show_bug.cgi?id=3653





------- Comment #12 from matt at mattmccutchen.net  2008-06-04 20:24 CST -------
Created an attachment (id=3335)
 --> (https://bugzilla.samba.org/attachment.cgi?id=3335&action=view)
Demonstration of two nasty vanishing cases

Even with the changes I proposed in comment 11, there are two cases in which
rsync's handling of a vanishing could be considered incorrect and thus merit a
warning and code 24.  They are both demonstrated in the attached script.

4. A source file causes rsync to delete a non-regular destination file (which
could even be a nonempty directory with --force) and then vanishes.  The end
result is that rsync deleted something from the destination without replacing
it, which shouldn't happen without --delete.

5. With --prune-empty-dirs, a source file preventing the pruning of its parent
directory and then vanishes.  The end result is that rsync creates an empty
directory, which isn't supposed to happen with --prune-empty-dirs.

Both of these seem rare and a pain to fix, and there are other other concurrent
modifications that cause code 23, such as replacing a regular file with a
directory, which can't be read(2).  I think making rsync completely correct and
warning-free in the face of concurrent modifications to the source is a losing
battle.  I propose that we focus on reducing the inconvenience in the common
case by suppressing the warning and code 24 for "safe" vanishings, namely new
source files in unprunable directories, and perhaps handling #3.  The need to
issue a code 23 when a mandatory file vanishes (#1) is a separate issue.


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.