log-checksum-diff [Re: CVS update: rsync/patches]

Matt McCutchen hashproduct+rsync at gmail.com
Sun Sep 2 15:22:41 GMT 2007

On 9/2/07, Wayne Davison <wayned at samba.org> committed:
> A slightly changed version of Matt's %C (checksum) logging patch.

Cool!  However, I'm not sure you need the special check to change a
checksum that is genuinely all zeros to all ones.  The risk of rsync
ignoring a read error because the checksum was all zeros is no greater
than the risk of rsync falsely concluding that a file was correctly
reconstructed due to a checksum collision.  Furthermore, files that
checksum to all zeros will inevitably confuse the user's determination
of whether the logged checksum is a bad one.


More information about the rsync mailing list