[feature request] Modify --backup option to make backups on source side, too

Matt McCutchen hashproduct+rsync at gmail.com
Mon Oct 15 14:31:14 GMT 2007

On 10/15/07, Aaron Digulla <digulla at hepe.com> wrote:
> Thanks for the input. If this wasn't for a production system, I'd do
> that :-) Why don't you apply the patch the release version?

Because the patch is a quick hack to serve a niche need, so the
benefit of saving people who need source backups a few steps does not
outweigh the cost of having it clutter up (and conceivably
destabilize) the main version of rsync for everyone else.

I think the model of a main version with the most important features
plus distributed patches for various extra features is an excellent
way to deliver a clean, stable rsync to the typical user but still
have implementations of the extra features available when needed.  In
fact, beginning in September 2005, I used a copy of rsync including a
patch for ACL support for nearly all copies on my computer.  The patch
was a complete hack and I really cared about ACLs, so I helped Wayne
improve the patch to the point where it was just as clean and stable
as the main code; then, in March 2007, Wayne elected to roll the patch
into the main version.  In the same way, I encourage you to test and
begin using the source-backup patch now if it suits your needs; if you
want the patch added to the main version, you can help make that more
likely by improving it.


More information about the rsync mailing list