DO NOT REPLY [Bug 3649] buffer overflow in receive_file_entry

[samba-bugs at samba.org]

https://bugzilla.samba.org/show_bug.cgi?id=3649


rsync at ofdan.co.uk changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rsync at ofdan.co.uk




------- Comment #2 from rsync at ofdan.co.uk  2006-06-07 07:25 MST -------
http://lists.samba.org/archive/rsync/2005-April/012104.html(In reply to comment
#1)
> The overflow error indicates that the data read over the socket for the size of
> the filename was somehow invalid (e.g. it might have gotten corrupted in
> transit). If you have a reproducable test case, I'd be glad to take a look at
> the bug.  If not, there's very little I can do.
> 

I have recieved a similiar error to the poster.


ERROR: buffer overflow in receive_file_entry
rsync error: error allocating core memory buffers (code 22) at util.c(126)

I also found a similiar error using google.com here..
http://lists.samba.org/archive/rsync/2005-April/012104.html

I have tested 2.6.6 and 2.6.8

This fix is for 2.6.8
The changes I have made to fix my error were in 

flist.c (489.c)

static struct file_struct *receive_file_entry(struct file_list *flist, unsigned
short flags, int f)

I changed the following lines:

        static char lastname[MAXPATHLEN], *lastdir;
        char thisname[MAXPATHLEN];

        if (l2 >= MAXPATHLEN - l1) {

to:

        static char lastname[BIGPATHBUFLEN], *lastdir;
        char thisname[BIGPATHBUFLEN];

        if (l2 >= BIGPATHBUFLEN - l1) {


I haven't done full debugged this, but it compiles and runs, and does what I
want so far.


The cause for this, was very long file names.


-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.