Return value ???

[Wayne Davison]

On Thu, Sep 29, 2005 at 11:59:53AM +0200, Judith Flo wrote:
> Excuse me,
> The permissions of the destination directory are 600 (no
> execution permissions neither for the user, nor the rest of users).

Ahhh!  That makes a big difference from mode 700 (which I assumed meant
that the dir was owned by a different user).  Also, including the actual
error message in your report is very helpful.  This allowed me to
pinpoint the stat() error in the generator that was only being reported
if verbosity was at least -vv.

The test for "verbose > 1" before outputting the stat() error is very
old, but doesn't make any sense to me.  I just removed it in CVS.  The
attached patch shows the change.

Thanks for your bug-report!

..wayne..
-------------- next part --------------
--- generator.c	6 Sep 2005 18:12:38 -0000	1.222
+++ generator.c	29 Sep 2005 17:04:37 -0000
@@ -1029,11 +1029,8 @@ static void recv_generator(char *fname, 
 			return;
 		if (stat_errno == ENOENT)
 			goto notify_others;
-		if (verbose > 1) {
-			rsyserr(FERROR, stat_errno,
-				"recv_generator: failed to stat %s",
-				full_fname(fname));
-		}
+		rsyserr(FERROR, stat_errno, "recv_generator: failed to stat %s",
+			full_fname(fname));
 		return;
 	}