Uninitialized static structure in generator.c/write_sum_head

Paul Slootman paul at debian.org
Sun Nov 28 11:10:15 GMT 2004


On Sat 27 Nov 2004, John E. Malmberg wrote:

> In the module generator.c, there is a static struct sum_struct null_sum 
> that is not initialized by any way that I can determine in the routine 
> write_sum_head.

A static data structure is guaranteed to be initialised to zero...

> Shouldn't it more correctly be:
> 
>     const struct sum_struct null_num = {0, 0, 0, 0, 0, NULL};

Perhaps more readable, but in no way more correct.


Paul Slootman


More information about the rsync mailing list