Uninitialized static structure in generator.c/write_sum_head
John E. Malmberg
wb8tyw at qsl.net
Sun Nov 28 01:51:06 GMT 2004
In the module generator.c, there is a static struct sum_struct null_sum
that is not initialized by any way that I can determine in the routine
write_sum_head.
Shouldn't it more correctly be:
const struct sum_struct null_num = {0, 0, 0, 0, 0, NULL};
This would also allow the declaration for the write_sum_head routine to
be as below, since the data that sum is pointing to is never modified.
void write_sum_head(int f, const struct sum_struct * sum)
-John
wb8tyw at qsl.net
Personal Opinion Only
More information about the rsync
mailing list