--from-files broken with remote sources

Andrew Pimlott andrew at pimlott.net
Tue Mar 30 21:41:17 GMT 2004


On Mon, Mar 29, 2004 at 03:45:18PM -0800, Wayne Davison wrote:
> On Mon, Mar 29, 2004 at 03:51:18PM -0500, Andrew Pimlott wrote:
> >     rsync -v --files-from files andrew at pimlott.net: .
> > and got an error from the remote rsync.
> 
> You can work around the problem by specifying a directory after the
> colon ('.' would work).

Oh, clever.

> -		if (*argc != 2) {
> +		if (*argc != 2 && (!am_server || !am_sender || *argc != 1)) {

Too many negatives for my brain!  I had to rewrite this as

    if (! (*argc == 2 || (am_server && am_sender && *argc == 1))) {

to see what it was doing.

Andrew


More information about the rsync mailing list